fix(aws-ecs): handle long ARN formats for services #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoManyHs
force-pushed
the
fix-autoscaling
branch
from
568261f to
e4b0b2f
Compare
Due to a bug in Cloudformation, Fn::GetAtt for service name on an ECS service was returning the cluster name instead of the service name. This was causing the ResourceId on AWS::ApplicationAutoScaling::ScalableTarget to be set incorrectly. This change forces the customer to specify whether they have opted into the long ARN format for services (which can be achieved through the following command: `aws ecs put-account-setting-default --name serviceLongArnFormat --value enabled`). The CDK cannot currently detect if the customer has the these settings enabled so there could be a potential conflict on deployment. Fixes aws#1849.
SoManyHs
force-pushed
the
fix-autoscaling
branch
from
e4b0b2f to
bcdda38
Compare
rix0rrr
reviewed
Apr 4, 2019
rix0rrr
reviewed
Apr 4, 2019
rix0rrr
reviewed
Apr 4, 2019
Test account won't be able to verify long ARN settings
rix0rrr
approved these changes
Apr 5, 2019
eladb
pushed a commit
that referenced
this pull request
Jul 3, 2019
Remove the temporary workaround implemented to allow long arns support: #2176 Removing the temporary workaround does not break anything for my account which has long arns enabled.
Kaixiang-AWS
pushed a commit
to Kaixiang-AWS/aws-cdk
that referenced
this pull request
Jul 3, 2019
Remove the temporary workaround implemented to allow long arns support: aws#2176 Removing the temporary workaround does not break anything for my account which has long arns enabled.
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
This was referenced Sep 24, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in Cloudformation, Fn::GetAtt for service name on an ECS
service was returning the cluster name instead of the service name. This
was causing the ResourceId on
AWS::ApplicationAutoScaling::ScalableTarget to be set incorrectly.
This change forces the customer to specify whether they have opted into
the long ARN format for services (which can be achieved through the following command:
aws ecs put-account-setting-default --name serviceLongArnFormat --value enabled). The CDK cannot currently detect if the customer has the thesesettings enabled so there could be a potential conflict on deployment.
Fixes #1849.
Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.