Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-applicationautoscaling): StepScalingPolicy missing ScalingTargetId and AdjustmentType #2522

Merged
merged 1 commit into from
May 20, 2019

Conversation

piradeepk
Copy link
Contributor

@piradeepk piradeepk commented May 10, 2019

Fix StepScalingAction and StepScalingPolicy to add ScalingTargetId and default AdjustmentType to CloudFormation template.


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

Sorry, something went wrong.

@piradeepk piradeepk requested a review from a team as a code owner May 10, 2019 22:54
@piradeepk piradeepk changed the title fix(aws-ecs): StepScalingPolicy fix(aws-applicationautoscaling): StepScalingPolicy missing ScalingTargetId and AdjustmentType May 10, 2019
Copy link
Contributor

@SoManyHs SoManyHs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@piradeepk
Copy link
Contributor Author

Added comment regarding why I've added the properties. Cloudformation requires either the ResourceId, ScalableDimension, and ServiceNamespace properties, or the ScalingTargetId property, but not both.

@SoManyHs
Copy link
Contributor

Ah -- I meant to add the context in the commit message, not in the code itself. Given that we may want to add those other three fields in the future, I figured it made more sense to give context in the commit only.

@rix0rrr rix0rrr merged commit 1f004f6 into aws:master May 20, 2019
piradeepk added a commit to piradeepk/aws-cdk that referenced this pull request May 20, 2019
Add ScalingTargetId and default AdjustmentType.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants