-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aws-applicationautoscaling): StepScalingPolicy missing ScalingTargetId and AdjustmentType #2522
Conversation
0791f27
to
e82cf18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
e82cf18
to
ef23cbc
Compare
Added comment regarding why I've added the properties. Cloudformation requires either the ResourceId, ScalableDimension, and ServiceNamespace properties, or the ScalingTargetId property, but not both. |
Ah -- I meant to add the context in the commit message, not in the code itself. Given that we may want to add those other three fields in the future, I figured it made more sense to give context in the commit only. |
Add ScalingTargetId and default AdjustmentType.
Fix StepScalingAction and StepScalingPolicy to add ScalingTargetId and default AdjustmentType to CloudFormation template.
Pull Request Checklist
design
folderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.