-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws-apigateway): add support for UsagePlan, ApiKey, UsagePlanKey #2564
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial feedback on README
- deduce the api from the stage object
Hi @eladb, thanks for reviewing. I've made a couple of changes you suggested. Could not wrap my head around the |
Hi @rix0rrr, I've updated the PR, maybe you can check when you have time. Thanks! |
Sorry, this has slipped my attention. Could you merge from master to make sure this still passes linter checks? We've added a couple in the mean time and I'd hate for a merge to break the build. |
Np, I've pulled in the changes... |
#723
Pull Request Checklist
design
folderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.