Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@aws-cdk/aws-ec2): vpc endpoint service name for SageMaker Notebook incorrect #2598

Merged
merged 1 commit into from
May 21, 2019
Merged

fix(@aws-cdk/aws-ec2): vpc endpoint service name for SageMaker Notebook incorrect #2598

merged 1 commit into from
May 21, 2019

Conversation

chriswessells
Copy link
Contributor

The service name was incorrect as per
https://docs.aws.amazon.com/sagemaker/latest/dg/notebook-interface-endpoint.html
I updated the name so it renders correctly. I tested it successfully
created a SageMaker Notebook endpoint

Changed one word.

Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

The service name was incorrect as per
https://docs.aws.amazon.com/sagemaker/latest/dg/notebook-interface-endpoint.html
I updated the name so it renders correctly. I tested it successfully
created a SageMaker Notebook endpoint
@chriswessells chriswessells requested a review from a team as a code owner May 21, 2019 00:03
@rix0rrr rix0rrr merged commit aec8ec2 into aws:master May 21, 2019
This was referenced Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants