Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(route53-targets): move Alias Targets into their own package #2617

Merged
merged 5 commits into from
May 23, 2019

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented May 23, 2019

In accordance with new guidelines, we're centralizing cross-service
integrations into their own package. In this case, centralizing
Route53 Alias Targets into @aws-cdk/aws-route53-targets.

Fixes #2448.

BREAKING CHANGE: using a CloudFront Distribution or an ELBv2
Load Balancer as an Alias Record Target now requires an integration
object from the @aws-cdk/aws-route53-targets package.


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

rix0rrr added 5 commits May 23, 2019 12:58
In accordance with new guidelines, we're centralizing cross-service
integrations into their own package. In this case, centralizing
Route53 Alias Targets into `@aws-cdk/aws-route53-targets`.

Fixes #2448.

BREAKING CHANGE: using a CloudFront Distribution or an ELBv2
Load Balancer as an Alias Record Target now requires an integration
object from the `@aws-cdk/aws-route53-targets` package.
@rix0rrr rix0rrr requested review from SoManyHs and a team as code owners May 23, 2019 12:43
@@ -134,7 +134,8 @@
"jsii-reflect": "^0.10.5",
"jsonschema": "^1.2.4",
"yaml": "1.5.0",
"yargs": "^13.2.2"
"yargs": "^13.2.2",
"@aws-cdk/aws-route53-targets": "^0.31.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcore nitpicking/bikeshedding, but I'd really like it if we could keep this list sorted alphabetically. Feel free to ignore though (it's not so important in the grand scheme of things).

@rix0rrr rix0rrr merged commit f40fe98 into master May 23, 2019
@rix0rrr rix0rrr deleted the huijbers/route53-targets branch May 23, 2019 14:05
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much cleaner. I am happy with this!

@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-route53-targets
4 participants