-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rds): add engineVersion to DatabaseCluster #2698
Conversation
+1 - I also need this change as I am trying to enable logical_replication which is only supported on postgres 10.6+ however the default instance type that is created is 9.6 :( |
@agdimech As a workaround in the meantime, you can copy the cluster.ts file from my branch and change the imports. That's what I'm doing. |
Haha I am already using it :p Thanks for this! |
Thanks for the contribution! Unfortunately, I've just merged some other RDS changes that lead to a conflict. Could you please merge from |
da13b5b
to
1da2f64
Compare
@rix0rrr Done. Rebased and force-pushed. |
1da2f64
to
8b0473f
Compare
Without this change, CDK's RDS DatabaseCluster is not very useful because you can only deploy the default versions of the given database engine. This change adds an optional prop `engineVersion` fixes aws#2212
8b0473f
to
a047963
Compare
I made a change directly to avoid a roundtrip. Hope I didn't break the build :) |
Thanks. Looks like you did not break the build. |
Has this change been merged into master or just your own dev branch? |
Without this change, CDK's RDS DatabaseCluster is not very useful
because you can only deploy the default versions
of the given database engine.
This change adds an optional prop
engineVersion
fixes #2212
Pull Request Checklist
design
folderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.