Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rds): add engineVersion to DatabaseCluster #2698

Merged
merged 2 commits into from
Jun 3, 2019

Conversation

joehillen
Copy link
Contributor

Without this change, CDK's RDS DatabaseCluster is not very useful
because you can only deploy the default versions
of the given database engine.

This change adds an optional prop engineVersion

fixes #2212


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@agdimech
Copy link

+1 - I also need this change as I am trying to enable logical_replication which is only supported on postgres 10.6+ however the default instance type that is created is 9.6 :(

@joehillen
Copy link
Contributor Author

joehillen commented May 31, 2019

@agdimech As a workaround in the meantime, you can copy the cluster.ts file from my branch and change the imports. That's what I'm doing.

@agdimech
Copy link

Haha I am already using it :p

Thanks for this!

@rix0rrr
Copy link
Contributor

rix0rrr commented May 31, 2019

Thanks for the contribution! Unfortunately, I've just merged some other RDS changes that lead to a conflict. Could you please merge from master and resolve them?

@joehillen joehillen force-pushed the rds-engineVersion branch from da13b5b to 1da2f64 Compare May 31, 2019 08:35
@joehillen
Copy link
Contributor Author

@rix0rrr Done. Rebased and force-pushed.

@joehillen joehillen force-pushed the rds-engineVersion branch from 1da2f64 to 8b0473f Compare May 31, 2019 09:43
Without this change, CDK's RDS DatabaseCluster is not very useful
because you can only deploy the default versions
of the given database engine.

This change adds an optional prop `engineVersion`

fixes aws#2212
@joehillen joehillen force-pushed the rds-engineVersion branch from 8b0473f to a047963 Compare May 31, 2019 10:29
@rix0rrr
Copy link
Contributor

rix0rrr commented May 31, 2019

I made a change directly to avoid a roundtrip. Hope I didn't break the build :)

@joehillen
Copy link
Contributor Author

Thanks. Looks like you did not break the build.

@agdimech
Copy link

agdimech commented Jun 3, 2019

Has this change been merged into master or just your own dev branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot specify an Aurora engine version
4 participants