refactor: Construct props must not use the 'any' type (awslint:props-no-any) #2701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…no-any) Adds a new awslint:props-no-any rule which validates that props do not use the "any" type. This is in accordance with the new AWS Construct Library guidelines. Fixes #2673
rix0rrr
approved these changes
May 31, 2019
| @@ -51,7 +51,7 @@ export interface PassProps { | |||
| * | |||
| * @default No injected result | |||
| */ | |||
| readonly result?: any; | |||
| readonly result?: {[key: string]: any}; | |||
There was a problem hiding this comment.
Call this out as a BREAKING CHANGE in the commit message that you merge.
| @@ -16,7 +16,7 @@ export interface SubscriptionProps { | |||
| * | |||
| * The meaning of this value depends on the value for 'protocol'. | |||
| */ | |||
| readonly endpoint: any; | |||
| readonly endpoint: string; | |||
There was a problem hiding this comment.
Call this out as a BREAKING CHANGE in the commit message that you merge.
4 tasks
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new awslint:props-no-any rule which validates that props do not use
the "any" type.
This is in accordance with the new AWS Construct Library guidelines.
Fixes #2673
Pull Request Checklist
designfolderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.