feat(aws-elasticloadbalancing): add crossZone property #2787
Conversation
Ability to enable cross-zone load balancing for a Classic Load Balancer closes aws#2786
| * | ||
| * @default - false. | ||
| */ | ||
| readonly crossZone?: boolean; |
There was a problem hiding this comment.
Does true make more sense as a default value here? I would feel better with that as a default value, and it seems the ELB team agrees:
According to: https://docs.aws.amazon.com/elasticloadbalancing/latest/classic/enable-disable-crosszone-lb.html
With the AWS Management Console, the option to enable cross-zone load balancing is selected by default.
Given that we kind of see the CDK as the "AWS console but without clicking", it makes sense to me that the recommended defaults would be the same between console and CDK.
There was a problem hiding this comment.
@rix0rrr good suggestion! I was just merely following the CloudFormation documentation.
I've updated my PR based on your recommendation. Let me know what you think.
Update from upstream
enable cross-zone load balancing by default to comply with AWS Console behaviour
Ability to enable cross-zone load balancing for a Classic Load Balancer
closes #2786