-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include @types/ dependencies in dependencies
not devDependencies
#2895
Closed
everett1992 opened this issue
Jun 17, 2019
· 1 comment
· Fixed by #2907 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Closed
Include @types/ dependencies in dependencies
not devDependencies
#2895
everett1992 opened this issue
Jun 17, 2019
· 1 comment
· Fixed by #2907 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Labels
bug
This issue is a bug.
Comments
I think in fact the real problem is that we should not be exporting symbols that depend on a particular 3P dependency. There is no actual need for they args declarations there (we can live with a much simpler, much more restrictive type here). |
RomainMuller
added a commit
that referenced
this issue
Jun 18, 2019
The settings.d.ts file was referencing `yargs`, but in fact only using the `yargs.Arguments` type as a stand-in for a `{ [key: string]: unknown }` alias. Replaced with the more restrictive type so we do not have an exported dependency on `yargs` types. Fixes #2895
RomainMuller
added a commit
that referenced
this issue
Jun 18, 2019
The settings.d.ts file was referencing `yargs`, but in fact only using the `yargs.Arguments` type as a stand-in for a `{ [key: string]: unknown }` alias. Replaced with the more restrictive type so we do not have an exported dependency on `yargs` types. Fixes #2895
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Typescript packages using aws-cdk cannot find a declaration file for module 'yargs'
To Reproduce
Create a typescript package that requires aws-cdk.
Typescript will type check libraries by default. It will fail checking aws-cdk because cdk does not include it's dependencies types in
dependencies
, it includes them indevDependencies
.Customers can fix this issue by
Expected behavior
There should not be any type errors in an effectively empty package. aws-cdk should include it's type dependencies in it's dependencies.
Version:
The text was updated successfully, but these errors were encountered: