Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ecs): rename hwType in EcsOptimizedAmiProps to `hardware… #2916

Merged
merged 1 commit into from
Jun 19, 2019
Merged

refactor(ecs): rename hwType in EcsOptimizedAmiProps to `hardware… #2916

merged 1 commit into from
Jun 19, 2019

Conversation

hencrice
Copy link
Contributor

…Type`

This change spells out the previously abbreviated hwType into hardwareType and it closes #2896.

BREAKING CHANGE: the property that specifies the type of EC2 AMI optimized for ECS was renamed to hardwareType from hwType.


Pull Request Checklist

  • [See below] Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking chaange)
    • [?] CLI change?: coordinate update of integration tests with team
      • scripts/run-integ-parallel @aws-cdk/aws-ecs passed (the command exits with 0). Not sure whether more needs to be done.
    • [?] cdk-init template change?: coordinated update of integration tests with team
      • scripts/run-integ-parallel @aws-cdk/aws-ecs passed (the command exits with 0). Not sure whether more needs to be done.
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • [N/A] Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

…Type`

This change spells out the previously abbreviated `hwType` into `hardwareType` and it closes #2896.

BREAKING CHANGE: the property that specifies the type of EC2 AMI optimized for ECS was renamed to `hardwareType` from `hwType`.
@hencrice hencrice requested review from SoManyHs and a team as code owners June 18, 2019 20:58
@rix0rrr rix0rrr merged commit 1aa0589 into aws:master Jun 19, 2019
This was referenced Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ecs: Rename hwType in EcsOptimizedAmiProps interface to hardwareType
2 participants