Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDS Cluster does not expose read endpoint correctly #2969

Closed
rpanfili opened this issue Jun 20, 2019 · 0 comments · Fixed by #2970 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Labels
bug This issue is a bug.

Comments

@rpanfili
Copy link
Contributor

There is a typo in RDS DatabaseCluster class so it exposes the write endpoint on property clusterReadEndpoint

The issue is here
https://github.com/awslabs/aws-cdk/blob/0dabb024a3ed136a0624d9a9a55561cc5e301147/packages/%40aws-cdk/aws-rds/lib/cluster.ts#L333

and can be easily fixed with this

    this.clusterReadEndpoint = new Endpoint(cluster.attrReadEndpointAddress, portAttribute);
@rpanfili rpanfili added the bug This issue is a bug. label Jun 20, 2019
rpanfili added a commit to rpanfili/aws-cdk that referenced this issue Jun 20, 2019
Fix a typo that exposes cluster write endpoint as `clusterReadEndpoint`
on RDS DatabaseCluster

fixes aws#2969
rpanfili added a commit to rpanfili/aws-cdk that referenced this issue Jun 21, 2019
Fix a typo that exposes cluster write endpoint as `clusterReadEndpoint`
on RDS DatabaseCluster

fixes aws#2969
rpanfili added a commit to rpanfili/aws-cdk that referenced this issue Jun 21, 2019
Fix a typo that exposes cluster write endpoint as `clusterReadEndpoint`
on RDS DatabaseCluster

fixes aws#2969
rix0rrr pushed a commit that referenced this issue Jun 21, 2019
Fix a typo that exposes cluster write endpoint as `clusterReadEndpoint` on RDS DatabaseCluster

Fixes #2969.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment