Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(codepipeline): change the API of cross-region replication Buckets #2977

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

skinny85
Copy link
Contributor

Users are now supposed to pass instances of IBucket instead of just Bucket names.

Changed the name and type of the Pipeline.crossRegionScaffold property.

BREAKING CHANGE: the Pipeline construction property crossRegionReplicationBuckets now takes values of type IBucket instead of string.

  • The property Pipeline.crossRegionScaffoldStacks has been renamed to crossRegionSupport,
    and its type changed from CrossRegionScaffoldStack to CrossRegionSupport.

Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

…ckets.

Users are now supposed to pass instances of IBucket instead of just Bucket names.

Changed the name and type of the Pipeline.crossRegionScaffold property.

BREAKING CHANGE: the Pipeline construction property crossRegionReplicationBuckets now takes values of type IBucket instead of string.
* The property Pipeline.crossRegionScaffoldStacks has been renamed to crossRegionSupport,
and its type changed from CrossRegionScaffoldStack to CrossRegionSupport.
@skinny85 skinny85 force-pushed the feature/cross-region-codepipeline branch from 65ba73b to 7503639 Compare June 21, 2019 19:35
@skinny85
Copy link
Contributor Author

Changed the name of the support Stack to <PipelineStackName>-support-<region>.

@skinny85 skinny85 merged commit 98afdeb into aws:master Jun 21, 2019
@skinny85 skinny85 deleted the feature/cross-region-codepipeline branch June 21, 2019 23:14
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants