Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecs): change the default generation to Amazon Linux v2 #3009

Merged
merged 3 commits into from
Jun 24, 2019
Merged

feat(ecs): change the default generation to Amazon Linux v2 #3009

merged 3 commits into from
Jun 24, 2019

Conversation

hencrice
Copy link
Contributor

This change make CDK consistent with the recommendataion we give customers: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-optimized_AMI.html. This closes #3005.

BREAKING CHANGE: Previously, the default generation is conditionally set to Amazon Linux v1 if hwType is STANDARD. Now it always default to Amazon Linux v2.


  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • [N/A] Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)
      By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

This change make CDK consistent with the recommendataion we give customers: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-optimized_AMI.html. This closes #3005.

BREAKING CHANGE: Previously, the default generation is conditionally set to Amazon Linux v1 if `hwType` is STANDARD. Now it always default to Amazon Linux v2.
@hencrice hencrice requested review from SoManyHs and a team as code owners June 22, 2019 00:16
@rix0rrr
Copy link
Contributor

rix0rrr commented Jun 22, 2019

Probably more integ tests that need updating

@hencrice
Copy link
Contributor Author

Probably more integ tests that need updating

Looks like unit tests (and likely integ tests) for other non-ECS services are failing. Will address them

@eladb eladb merged commit 32e3421 into aws:master Jun 24, 2019
@hencrice hencrice deleted the hencrice/standard-is-amzn-linux-2 branch June 24, 2019 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ecs: the default Amazon Linux generation should be v2
3 participants