Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamodb): support RemovalPolicy #3028

Merged
merged 8 commits into from
Jun 26, 2019

Conversation

RomainMuller
Copy link
Contributor

Add support for RemovalPolicy on DynamoDB Tables, defaulting to
RemovalPolicy.RETAIN as the resource is inherently stateful.


Please read the contribution guidelines and follow the pull-request checklist.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license


Add support for RemovalPolicy on DynamoDB `Table`s, defaulting to
`RemovalPolicy.RETAIN` as the resource is inherently stateful.
@RomainMuller RomainMuller requested a review from a team as a code owner June 24, 2019 11:29
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing test

packages/@aws-cdk/aws-dynamodb/lib/table.ts Outdated Show resolved Hide resolved
@RomainMuller RomainMuller requested a review from eladb June 24, 2019 12:24
@RomainMuller RomainMuller changed the title feat(dynamodb): Support RemovalPolicy feat(dynamodb): support RemovalPolicy Jun 25, 2019
@RomainMuller RomainMuller self-assigned this Jun 25, 2019
@RomainMuller RomainMuller merged commit a6175be into master Jun 26, 2019
@RomainMuller RomainMuller deleted the rmuller/dynamodb-removal-policy branch June 26, 2019 10:27
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants