fix(sns): create subscriptions in consumer scope #3065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since in most cases the consumer needs to reference the topic to permit it to send them messages (e.g. invoke a lambda function or send messages to the queue), it makes much more send to create the SNS subscription resource on the consumer's scope/stack instead of the topic's. This change adds an optional `scope` field to `TopicSubscriptionConfig` which is respected by `topic.addSubscription`. If `scope` is not defined, the topic's scope will be used. We also changed `subscriberId` to be optional, since in the case where `scope` is specified, the natural ID for the subscription construct would be the topic's unique ID, which is now the default. A runtime error will be emitted if both `scope` and `subscriberId` are not provided. Fixes #3064
ghost
requested a review
from 
rix0rrr
approved these changes
Jun 26, 2019
shivlaks
added a commit
that referenced
this pull request
Jun 27, 2019
Follow-up to address changes introduced in #3065
shivlaks
added a commit
that referenced
this pull request
Jun 27, 2019
Follow-up to address changes introduced in #3065
This was referenced Aug 22, 2019
|
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
This was referenced Sep 24, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since in most cases the consumer needs to reference the topic to
permit it to send them messages (e.g. invoke a lambda function or send
messages to the queue), it makes much more send to create the SNS subscription
resource on the consumer's scope/stack instead of the topic's.
This change adds an optional
scopefield toTopicSubscriptionConfigwhichis respected by
topic.addSubscription. Ifscopeis not defined, the topic'sscope will be used. We also changed
subscriberIdto be optional, since in thecase where
scopeis specified, the natural ID for the subscription constructwould be the topic's unique ID, which is now the default. A runtime error will
be emitted if both
scopeandsubscriberIdare not provided.Fixes #3064
Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license