-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Gap / Interface Mismatch: AlarmWidget, Alarm, and IAlarm #3068
Closed
BBonifield opened this issue
Jun 26, 2019
· 1 comment
· Fixed by #3219 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Closed
Feature Gap / Interface Mismatch: AlarmWidget, Alarm, and IAlarm #3068
BBonifield opened this issue
Jun 26, 2019
· 1 comment
· Fixed by #3219 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Labels
Comments
Confirming this is an issue. @shivlaks we should update our awslint rule to cover more than just props... |
rix0rrr
added
bug
This issue is a bug.
@aws-cdk/aws-cloudwatch
Related to Amazon CloudWatch
labels
Jun 26, 2019
rix0rrr
added a commit
that referenced
this issue
Jul 5, 2019
This allows using an imported alarm. Fixes #3068.
eladb
pushed a commit
that referenced
this issue
Jul 7, 2019
This allows using an imported alarm. Fixes #3068.
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
This was referenced Sep 24, 2024
Open
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm not sure if this is intended or an oversight, but
AlarmWidgetProps
is setup withreadonly alarm: Alarm;
rather thanreadonly alarm: IAlarm;
. This prevents you from referencing alarms viaCloudwatch.Alarm.fromAlarmArn
, which returns anIAlarm
.I ask because, for the underlying Cloudformation DashboadBody, I believe the following JSON structure is allowed, and it only requires the ARN:
Thanks!
The text was updated successfully, but these errors were encountered: