Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(elasticloadbalancingv2): fix to be able to set deregistrationDelay #3075

Merged
merged 6 commits into from
Jun 30, 2019

Conversation

cohalz
Copy link
Contributor

@cohalz cohalz commented Jun 26, 2019

Fixes: #3074


Please read the contribution guidelines and follow the pull-request checklist.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@cohalz cohalz requested a review from a team as a code owner June 26, 2019 06:55
@ghost ghost requested a review from eladb June 26, 2019 06:55
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a unit test?

@cohalz cohalz changed the title fix(elasticloadbalancingv2): fix tobe able to set deregistrationDelay fix(elasticloadbalancingv2): fix to be able to set deregistrationDelay Jun 26, 2019
@cohalz
Copy link
Contributor Author

cohalz commented Jun 27, 2019

unit test added

@mhuebner
Copy link

Any chance to get this merged very soon?

@eladb eladb merged commit 22ab4b4 into aws:master Jun 30, 2019
@mhuebner
Copy link

mhuebner commented Jul 1, 2019

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

elasticloadbalancingv2: fix to be able to set deregistrationDelay
3 participants