-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(codepipeline-actions): set service as backing resource for EcsDeployAction #3085
Merged
eladb
merged 2 commits into
aws:master
from
strax:strax/cross-account-ecs-deploy-action
Jun 27, 2019
Merged
fix(codepipeline-actions): set service as backing resource for EcsDeployAction #3085
eladb
merged 2 commits into
aws:master
from
strax:strax/cross-account-ecs-deploy-action
Jun 27, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomainMuller
approved these changes
Jun 26, 2019
Thanks for the subtle PR @strax ! Note that I haven't explicitly tested whether cross-account support works for ECS services (yet) - it might be that we will need to create some Roles inside the service, for example, with a lazy-assigned physical name. Let us know what you find out! Thanks, |
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds cross-account deployment support to
EcsDeployAction
CodePipeline action by setting theActionProperties.resource
property introduced in #3012 to the target ECS service.Pull Request Checklist
design
folderPlease read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license