fix(events): correct token resolution in RuleTargetInput #3127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
eladb
approved these changes
Jun 30, 2019
rix0rrr
reviewed
Jul 1, 2019
| @@ -148,7 +148,7 @@ class FieldAwareEventInput extends RuleTargetInput { | |||
| } | |||
|
|
|||
| public resolveToken(t: Token, _context: IResolveContext) { | |||
| if (!isEventField(t)) { return t; } | |||
| if (!isEventField(t)) { return Token.asString(t); } | |||
There was a problem hiding this comment.
Yeah, it used to inherit a working toString(). Implementing that on the Token would also have worked. I think I would feel safer if we did that... but that can wait until we uncover a new failing case maybe.
There was a problem hiding this comment.
Would it have worked with token encoded as numbers?
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3119
Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license