Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codepipeline): mark crossRegionReplicationBuckets and crossRegionSupport as experimental #3226

Merged
merged 1 commit into from
Jul 8, 2019

Conversation

skinny85
Copy link
Contributor

@skinny85 skinny85 commented Jul 7, 2019

BREAKING CHANGE: codepipeline.Pipeline.crossRegionReplicationBuckets is now experimental

  • codepipeline.Pipeline.crossRegionSupport is now experimental
  • codepipeline.CrossRegionSupport is now experimental

Please read the contribution guidelines and follow the pull-request checklist.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@skinny85 skinny85 requested a review from eladb July 7, 2019 02:55
@skinny85 skinny85 requested review from RomainMuller and a team as code owners July 7, 2019 02:55
packages/@aws-cdk/aws-codepipeline/lib/pipeline.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-codepipeline/lib/pipeline.ts Outdated Show resolved Hide resolved
@skinny85 skinny85 force-pushed the fix/codepipeline-breaking-changes branch from fc5741b to 2ab080f Compare July 7, 2019 17:11
@skinny85
Copy link
Contributor Author

skinny85 commented Jul 7, 2019

Changed to use @experimental in the new revision.

…Support as experimental.

BREAKING CHANGE: codepipeline.Pipeline.crossRegionReplicationBuckets is now experimental
* codepipeline.Pipeline.crossRegionSupport is now experimental
* codepipeline.CrossRegionSupport is now experimental
@skinny85 skinny85 force-pushed the fix/codepipeline-breaking-changes branch from 2ab080f to 9b8a41a Compare July 8, 2019 15:44
@skinny85
Copy link
Contributor Author

skinny85 commented Jul 8, 2019

Changed to @experimental for all properties and types.

Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update PR title & description please

@skinny85 skinny85 changed the title fix(codepipeline): rename crossRegionReplicationBuckets and hide cros… fix(codepipeline): mark crossRegionReplicationBuckets and crossRegionSupport as experimental Jul 8, 2019
@skinny85 skinny85 merged commit f8256e7 into aws:master Jul 8, 2019
@skinny85 skinny85 deleted the fix/codepipeline-breaking-changes branch July 8, 2019 16:58
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants