Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Create a "How-To Tag my Resources" section #360

Closed
Doug-AWS opened this issue Jul 17, 2018 · 5 comments
Closed

docs: Create a "How-To Tag my Resources" section #360

Doug-AWS opened this issue Jul 17, 2018 · 5 comments
Assignees
@Doug-AWS
Labels
docs/guide Related to the developer guide effort/small Small work item – less than a day of effort p1 pr/work-in-progress This PR is a draft and needs further work.

Comments

@Doug-AWS
Copy link
Contributor

No description provided.

@Doug-AWS
Copy link
Contributor Author

See PR #538

@Doug-AWS Doug-AWS mentioned this issue Aug 13, 2018
Merged
@Doug-AWS Doug-AWS changed the title Create a "How-To Tag my Resources" section in the docs docs: Create a "How-To Tag my Resources" section in the docs Aug 13, 2018
@srchase srchase added guidance Question that needs advice or information. and removed how-to labels Jan 3, 2019
@Doug-AWS Doug-AWS added the docs/guide Related to the developer guide label Jan 23, 2019
@Doug-AWS
Copy link
Contributor Author

I'm working on this now.

@Doug-AWS Doug-AWS added p1 effort/small Small work item – less than a day of effort investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed p2 labels Jan 29, 2019
eladb pushed a commit that referenced this issue Feb 6, 2019
@moofish32
feat(cdk): aspect framework and tag implementation (#1451)
f7c8531 
A generalized aspect framework is added. Aspects can be used to affect the construct tree without modifying the class hierarchy. This framework is designed to be generic for future use cases. Tagging is the first implementation.

Tagging has been reimplemented to leverage the aspect framework and simplify the original tag design. Tag Manager still exists, but is no longer intended for use by L2 construct authors. There are two new classes `cdk.Tag` and `cdk.RemoveTag`. As new resources are added tag support will be automatic as long as they implement one of the existing tag specifications. All L2 constructs have removed the TagManager.

Code generation has been modified to add tag support to any CloudFormation Resource with a matching specification, by creating a Tag Manager for that resource as a `tags` attribute. The schema code now includes the ability to detect 3 forms of tags which include the current CloudFormation Resources.

BREAKING CHANGE: if you are using TagManager the API for this object has completely changed. You should no longer use TagManager directly, but instead replace this with Tag Aspects. `cdk.Tag` has been renamed to `cdk.CfnTag` to enable `cdk.Tag` to be the Tag Aspect.

Fixes #1136
Fixes #1497 
Related #360
@eladb
Copy link
Contributor

eladb commented Feb 6, 2019

@Doug-AWS FYI: #1451

@Doug-AWS Doug-AWS self-assigned this Feb 26, 2019
@Doug-AWS Doug-AWS added pr/work-in-progress This PR is a draft and needs further work. and removed guidance Question that needs advice or information. investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Feb 26, 2019
@Doug-AWS
Copy link
Contributor Author

I'm going to tackle this today.

@Doug-AWS Doug-AWS changed the title docs: Create a "How-To Tag my Resources" section in the docs docs: Create a "How-To Tag my Resources" section Feb 26, 2019
@Doug-AWS
Copy link
Contributor Author

See https://docs.aws.amazon.com/CDK/latest/userguide/constructs.html#constructs_tagging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Doug-AWS Doug-AWS

Labels
docs/guide Related to the developer guide effort/small Small work item – less than a day of effort p1 pr/work-in-progress This PR is a draft and needs further work.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eladb @srchase @Doug-AWS