Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Move the Lambda Invoke CodePipeline Action #401

Merged
merged 1 commit into from
Jul 25, 2018
Merged

[BREAKING] Move the Lambda Invoke CodePipeline Action #401

merged 1 commit into from
Jul 25, 2018

Conversation

skinny85
Copy link
Contributor

@skinny85 skinny85 commented Jul 24, 2018

This commit moves the Lambda Invoke Action from the codepipeline module to its dedicated,
new lambda-codepipeline module.
It's not possible to move it to the lambda module itself,
as that would cause a cyclic dependency between the codepipeline,
sns and lambda modules.

This continues the refactoring of moving out concrete Action typesfrom the codepipeline module.


Continued from #348


By submitting this pull request, I confirm that my contribution is made under
the terms of the beta license.

@skinny85
Copy link
Contributor Author

Forgot to update the imported module names in the ReadMe with the newaws- prefix.

Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please shorten PR title and elaborate in description.

This commit moves the Lambda Invoke Action from the codepipeline module to its dedicated,
new lambda-codepipeline module.
It's not possible to move it to the lambda module itself,
as that would cause a cyclic dependency between the codepipeline,
sns and lambda modules.

This continues the refactoring of moving out concrete Action typesfrom the codepipeline module.
@skinny85 skinny85 changed the title [BREAKING] Moved the LambdaInvoke Action from the codepipeline module to its dedicated, new lambda-codepipeline module [BREAKING] Move the Lambda Invoke CodePipeline Action Jul 25, 2018
@skinny85
Copy link
Contributor Author

Please shorten PR title and elaborate in description.

Done.

@eladb eladb merged commit 26c03d0 into aws:master Jul 25, 2018
@skinny85 skinny85 deleted the feature/lambda-action-move2 branch July 30, 2018 18:24
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants