Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdk-init fail with an error #409

Closed
eladb opened this issue Jul 25, 2018 · 0 comments · Fixed by #413
Closed

cdk-init fail with an error #409

eladb opened this issue Jul 25, 2018 · 0 comments · Fixed by #413
Labels
bug This issue is a bug.

Comments

@eladb
Copy link
Contributor

eladb commented Jul 25, 2018

The error is: Cannot find module '@aws-cdk/cdk/package.json'
@eladb eladb changed the title cdk-init typescript fails with an error cdk-init java/typescript fails with an error Jul 25, 2018
@eladb eladb changed the title cdk-init java/typescript fails with an error cdk-init fail with an error Jul 25, 2018
@eladb eladb added the bug This issue is a bug. label Jul 25, 2018
eladb pushed a commit that referenced this issue Jul 26, 2018
cdk-init bug fix
e924a4c 
Since the toolkit doesn't depend on the framework anymore, "cdk init" cannot obtain
the version of @aws-cdk/cdk when it expands
templates. Since our repo currently uses a
monolithic version number, we can just use
the toolkit's version for that.

Also, remove unreachable code from spec-diff.ts

Fixes #409
@eladb eladb mentioned this issue Jul 26, 2018
Merged
eladb pushed a commit that referenced this issue Jul 26, 2018
cdk-init bug fix (#413)
0543402 
Since the toolkit doesn't depend on the framework anymore, "cdk init" cannot obtain
the version of @aws-cdk/cdk when it expands
templates. Since our repo currently uses a
monolithic version number, we can just use
the toolkit's version for that.

Also, remove unreachable code from spec-diff.ts

Fixes #409
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cdk-init bug fix aws/aws-cdk
1 participant
@eladb