feat(aws-codedeploy): Add the auto-scaling groups property to ServerDeploymentGroup #739

skinny85 · 2018-09-18T23:42:51Z

Also automate the process of installing the CodeDeploy agent.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

skinny85 · 2018-09-19T00:21:33Z

Forgot to update the README file.

rix0rrr · 2018-09-19T08:33:15Z

packages/@aws-cdk/aws-codedeploy/lib/deployment-group.ts

+            switch (agentInstallationType) {
+                case AgentInstallationType.UBUNTU_14_04:
+                    asg.addUserData(`
+                        apt-get update -y


Not too keen on the embedded newlines here. Mind doing something like this:

asg.addUserData([ 'apt-get update -y', 'apt-get install', ... ].join('\n'));

Honestly we need to make UserData an object with a richer API, and hide the platform differences in there as well.

Or hide user data all together and opt for LaunchConfig :)

IMO it's a cleaner thing to say

asg.defaultConfigSet.addRPMInstall("someUrl") and expose all the similar method (.addFile(contents)) etc.

Honestly we need to make UserData an object with a richer API, and hide the platform differences in there as well.

I'll try to come up with something.

mindstorms6 · 2018-09-19T10:11:53Z

packages/@aws-cdk/aws-codedeploy/lib/deployment-group.ts

+                        yum install ruby wget -y
+                        TMP_DIR=\`mktemp -d\`
+                        cd $TMP_DIR
+                        wget https://aws-codedeploy-${region}.s3.amazonaws.com/latest/install


We should opt to move all of these to the aws s3 cp version - the url pattern above won't work across regions/partitions. The AWS CLI should handle the right endpoint selection even in fun regions.

Will change to using the AWS CLI.

mindstorms6 · 2018-09-19T10:19:13Z

packages/@aws-cdk/aws-codedeploy/lib/deployment-group.ts

+        }
+
+        const stack = cdk.Stack.find(this);
+        const region = stack.requireRegion('Could not determine the region to download the CodeDeploy agent from');


This is probably controversial... but why wouldn't we use the AWS::Region psuedo parameter here? I know it's not cdk like... but are we effectively forcing people into the env model?

I agree with @mindstorms6. If it's possible to use AwsRegion, then it's usually preferred at these low-layers.

This should work for you:

const region = (new cdk.AwsRegion()).toString();

It will render a "stringified token" that you can naturally embed into other strings. Upon synthesis, these stringified tokens will be converted to FnJoin expressions. Magic!

Will embedding AWS::Region in User Data actually work? I thought CloudFormation only expanded it in "function calls" like Fn::Join, etc.?

If you use the method I described, it should work. But you should also test it both in a unit test and an integ test

eladb · 2018-09-19T11:44:34Z

packages/@aws-cdk/aws-codedeploy/lib/deployment-group.ts

+     * @default the agent will not be automatically installed
+     * @see https://docs.aws.amazon.com/codedeploy/latest/userguide/codedeploy-agent-operations-install.html
+     */
+    agentInstallationType?: AgentInstallationType;


Isn't it possible to deduce the OS type from the AutoScalingGroup?

Yes, except the instructions are different for different flavors of Linux.

However, after consulting with the CodeDeploy team, I've decided to try and write one script that will work on all of the Linux distributions. Will change.

eladb · 2018-09-19T11:44:48Z

packages/@aws-cdk/aws-codedeploy/lib/deployment-group.ts

+     *
+     * @default []
+     */
+    autoScalingGroups?: autoscaling.AutoScalingGroup[];


Not sure we have it, but can we use AutoScalingGroupRef?

I guess we need one. Issue?

eladb · 2018-09-19T11:45:14Z

packages/@aws-cdk/aws-codedeploy/lib/deployment-group.ts

        });

        this.deploymentGroupName = resource.ref;
        this.deploymentGroupArn = deploymentGroupName2Arn(this.application.applicationName,
            this.deploymentGroupName);
    }
+
+    public get autoScalingGroups(): autoscaling.AutoScalingGroup[] {


What's the rational for cloning?

Arrays are mutable, so we defensively copy them in accessors. We do it in a ton of places already (Pipeline, for example).

Why would someone need to be able to access the list of ASGs?

We will need it in the CodeDeploy Pipeline Action (we need to add permissions to each ASG to read from the Pipeline Bucket).

eladb · 2018-09-19T11:45:35Z

packages/@aws-cdk/aws-codedeploy/lib/deployment-group.ts

+        return this._autoScalingGroups.slice();
+    }
+
+    private addCodeDeployAgentInstallUserData(agentInstallationType?: AgentInstallationType): void {


Should we emit an error if agent deployment is requested without ASGs?

I want to change this to a boolean that is true by default after handling this comment, and at that point that validation will not be needed.

eladb · 2018-09-19T11:46:17Z

packages/@aws-cdk/aws-codedeploy/lib/deployment-group.ts


        const resource = new cloudformation.DeploymentGroupResource(this, 'Resource', {
            applicationName: this.application.applicationName,
            deploymentGroupName: props && props.deploymentGroupName,
            serviceRoleArn: this.role.roleArn,
            deploymentConfigName: props && props.deploymentConfig &&
                props.deploymentConfig.deploymentConfigName,
+            autoScalingGroups: props && props.autoScalingGroups &&
+                props.autoScalingGroups.map(asg => asg.autoScalingGroupName()),
        });

        this.deploymentGroupName = resource.ref;
        this.deploymentGroupArn = deploymentGroupName2Arn(this.application.applicationName,
            this.deploymentGroupName);
    }


Would it be useful to also support addAutoScalingGroup?

eladb · 2018-09-19T11:47:14Z

packages/@aws-cdk/aws-codedeploy/lib/deployment-group.ts

+        }
+
+        const stack = cdk.Stack.find(this);
+        const region = stack.requireRegion('Could not determine the region to download the CodeDeploy agent from');


I agree with @mindstorms6. If it's possible to use AwsRegion, then it's usually preferred at these low-layers.

This should work for you:

const region = (new cdk.AwsRegion()).toString();

It will render a "stringified token" that you can naturally embed into other strings. Upon synthesis, these stringified tokens will be converted to FnJoin expressions. Magic!

eladb · 2018-09-19T11:50:12Z

packages/@aws-cdk/aws-codedeploy/package.json

@@ -41,7 +41,7 @@
  },
  "nyc": {
    "lines": 50,
-    "branches": 40
+    "branches": 30


Because there wasn't an easy way of asserting on the User Data in the tests, and I'd rather not copy&paste the entire script in the tests.

Sorry but that’s not an excuse not to test something. If you need to maintain a copy as an expected file to ensure that your code works, then that’s what you should do.

eladb · 2018-09-19T11:50:53Z

packages/@aws-cdk/aws-codedeploy/test/test.deployment-group.ts

+
+            new codedeploy.ServerDeploymentGroup(stack, 'DeploymentGroup', {
+                autoScalingGroups: [asg],
+            });


I think deploymentGroup.addAutoScalingGroup(asg) will be a nice addition to the API

skinny85 · 2018-09-20T01:14:13Z

Updated including (hopefully) everybody's comments.

skinny85 · 2018-09-20T01:15:43Z

packages/@aws-cdk/aws-codedeploy/README.md

@@ -28,6 +28,9 @@ To create a new CodeDeploy Deployment Group that deploys to EC2/on-premise insta
 const deploymentGroup = new codedeploy.ServerDeploymentGroup(this, 'CodeDeployDeploymentGroup', {
    application,
    deploymentGroupName: 'MyDeploymentGroup',
+    autoScalingGroups: [asg1, asg2],
+    // automatically installs the CodeDeploy agent on your auto-scaling groups hosts:
+    agentInstallationType: codedeploy.AgentInstallationType.AMAZON_LINUX_RHEL,


Forgot to update this part of the README - will fix.

yubangxi · 2018-09-20T17:34:24Z

packages/@aws-cdk/aws-codedeploy/lib/deployment-group.ts

+
+        switch (asg.osType) {
+            case ec2.OperatingSystemType.Linux:
+                asg.addUserData(


Assuming this user data has been fully tested on different OS per https://docs.aws.amazon.com/codedeploy/latest/userguide/codedeploy-agent.html

Tested on Ubuntu 14.04, Ubuntu 16.04 and Amazon Linux.

skinny85 · 2018-09-20T19:51:23Z

Updated the README.

eladb · 2018-09-20T20:08:17Z

packages/@aws-cdk/aws-codedeploy/README.md

+    autoScalingGroups: [asg1, asg2],
+    // automatically installs the CodeDeploy agent on your auto-scaling groups hosts
+    // default: true
+    autoInstallAgent: true,


rename to installAgent, not sure what "automatic" about it 😉

skinny85 · 2018-09-20T20:17:13Z

Missed the dependency on S3 when rebasing (versions changed to 0.9.2).

eladb

Looks good. Minor tips

eladb · 2018-09-20T20:11:35Z

packages/@aws-cdk/aws-codedeploy/lib/deployment-group.ts

@@ -88,6 +92,10 @@ class ImportedServerDeploymentGroupRef extends ServerDeploymentGroupRef {
        this.deploymentGroupArn = deploymentGroupName2Arn(props.application.applicationName,
            props.deploymentGroupName);
    }
+
+    public get autoScalingGroups(): autoscaling.AutoScalingGroup[] {


I don't think autoScalingGroups should be part of the API for ServerDeploymentGroupRef. The API of ServerDeploymentGroupRef should reflect the common denominator. It is impossible to determine the ASGs associated with an imported ServerDeploymentGroup.

It has to be (the argument to the CodePipeline Deploy Action must be a ServerDeploymentGroupRef, exactly like it's ProjectRef for CodeBuild, and RepositoryRef for CodeCommit). So, for a reference, we simply won't have any ASGs (like we often have an undefined Role for reference objects).

I see... Why does the deploy action needs access to the ASGs? What would be the degraded experience if I am importing a deployment group?

Because it needs to grant each ASG permissions to read from the CodePipeline S3 Bucket. If you don't do this, deployments in that Pipeline will always fail.

Otherwise, the customer has to do this permissions granting themselves, which the L2s are supposed to abstract away.

Got it. Thanks!
Maybe worth documenting the motivation for exposing this here.

In such cases we plan to issue some form of notification during synthesis that tells the user that they should make sure some permissions are required. I wonder if you should make this an optional field, so the call site (in this case, the Action), will be able to determine how to deal with the fact that it can't access the list of ASGs. It will be a more accurate representation of that fact than an empty array.

I don't hate that idea. The one thing that I don't like is that JSII forces overridden properties to have the same type. So, you can't do autoScalingGroups?: AutoScalingGroup[] in ServerDeploymentGroupRef, and then autoScalingGroups: AutoScalingGroup[] in ServerDeploymentGroup. Which means everybody interacting with ServerDeploymentGroup will deal with an optional type, while in reality it can never be undefined. I'm not sure if that's not too inconveniencing for a small gain.

Let me know what you think.

Yes, I realize. But I still think that if this is part of the low level interface, it’s better represented as an optional.

OK then. I'll change it to autoScalingGroups?: AutoScalingGroup[] in ServerDeploymentGroupRef. I'll probably also add role?: Role while I'm at it.

eladb · 2018-09-20T20:11:51Z

packages/@aws-cdk/aws-codedeploy/lib/deployment-group.ts

+     *
+     * @default []
+     */
+    autoScalingGroups?: autoscaling.AutoScalingGroup[];


I guess we need one. Issue?

eladb · 2018-09-20T20:11:59Z

packages/@aws-cdk/aws-codedeploy/lib/deployment-group.ts

+     * @default true
+     * @see https://docs.aws.amazon.com/codedeploy/latest/userguide/codedeploy-agent-operations-install.html
+     */
+    autoInstallAgent?: boolean;


installAgent

eladb · 2018-09-20T20:13:35Z

packages/@aws-cdk/aws-codedeploy/lib/deployment-group.ts

@@ -142,18 +171,80 @@ export class ServerDeploymentGroup extends ServerDeploymentGroupRef {
            managedPolicyArns: ['arn:aws:iam::aws:policy/service-role/AWSCodeDeployRole'],
        });

+        this._autoScalingGroups = props.autoScalingGroups || [];
+        this.autoInstallAgent = props.autoInstallAgent !== false;


A bit more readable in my opinion is to explicitly check for undefined:

this.installAgent = props.installAgent !== undefined ? props.installAgent : true;

It's also a lot more verbose, that's why I prefer the false comparison, but sure, I'll change it :)

eladb · 2018-09-20T20:17:52Z

packages/@aws-cdk/aws-codedeploy/lib/deployment-group.ts

@@ -130,6 +154,11 @@ export class ServerDeploymentGroup extends ServerDeploymentGroupRef {
    public readonly deploymentGroupArn: string;
    public readonly deploymentGroupName: string;

+    private readonly _autoScalingGroups: autoscaling.AutoScalingGroup[];
+    private readonly autoInstallAgent: boolean;
+    private readonly region: string = (new cdk.AwsRegion()).toString();


No need to store, just evaluate in addCodeDeployAgentInstallUserData.

eladb · 2018-09-20T20:21:18Z

packages/@aws-cdk/aws-codedeploy/lib/deployment-group.ts

+        return this._autoScalingGroups.slice();
+    }
+
+    private addCodeDeployAgentInstallUserData(asg: autoscaling.AutoScalingGroup): void {


This is awesome!

Some pretty sketchy Bash in there, but it seems to get the work done :)

…eploymentGroup.

skinny85 · 2018-09-21T17:28:57Z

Changed the autoScalingGroups property to be optional.

* **aws-codecommit:** typo in README ([#780](#780)) ([0e79c2d](0e79c2d)) * **aws-ec2:** fix capitalization of "VPCEndpointType" to "VpcEndpointType" ([#789](#789)) ([7a8ee2c](7a8ee2c)), closes [#765](#765) * **docs:** fix issue [#718](#718) (Aurora DB example) ([#783](#783)) ([016f3a8](016f3a8)) * **util:** remove [@aws-cdk](https://github.com/aws-cdk)/util ([#745](#745)) ([10015cb](10015cb)), closes [#709](#709) * **aws-cloudformation:** rename the CodePipeline actions ([#771](#771)) ([007e7b4](007e7b4)) * **aws-cloudformation:** update the README of the module to reflect the new action names ([#775](#775)) ([6c0e75b](6c0e75b)), closes [#771](#771) * **aws-codedeploy:** add auto-scaling groups property to ServerDeploymentGroup ([#739](#739)) ([0b28886](0b28886)) * **aws-codedeploy:** add deployment configuration construct ([#653](#653)) ([e6b67ad](e6b67ad)) * **aws-codepipeline, aws-codecommit, aws-s3:** change the convention for naming the source Actions to XxxSourceAction ([#753](#753)) ([9c3ce7f](9c3ce7f)) * **aws-elasticloadbalancingv2:** support for ALB/NLB ([#750](#750)) ([bd9ee01](bd9ee01)) * tagging support for AutoScaling/SecurityGroup ([#766](#766)) ([3d48eb2](3d48eb2)) * **core:** resource overrides (escape hatch) ([#784](#784)) ([5054eef](5054eef)), closes [#606](#606) * **toolkit:** stop creating 'empty' stacks ([#779](#779)) ([1dddd8a](1dddd8a)) * **cdk**: the constructor signature of `TagManager` has changed. `initialTags` is now passed inside a props object. * **util:** `@aws-cdk/util` is no longer available * **aws-elasticloadbalancingv2:** adds classes for modeling Application and Network Load Balancers. AutoScalingGroups now implement the interface that makes constructs a load balancing target. The breaking change is that Security Group rule identifiers have been changed in order to make adding rules more reliable. No code changes are necessary but existing deployments may experience unexpected changes. * **aws-cloudformation:** this renames all CloudFormation Actions for CodePipeline to bring them in line with Actions defined in other service packages. * **aws-codepipeline, aws-codecommit, aws-s3:** change the names of the source Actions from XxxSource to XxxSourceAction. This is to align them with the other Actions, like Build. Also, CodeBuild has the concept of Sources, so it makes sense to strongly differentiate between the two.

Bug Fixes --------- * **aws-apigateway:** allow + in path parts ([#769](#769)) ([0c50d27](0c50d27)), closes [#768](#768) * **aws-cdk:** continue after exceptions in stack monitor ([#791](#791)) ([b0f3298](b0f3298)), closes [#787](#787) * **aws-cloudfront:** check for undefined and determining of the defaultRootObject prop is set or not ([#801](#801)) ([32a74c6](32a74c6)) * **aws-cloudfront:** properly support loggingConfig ([#809](#809)) ([5512f70](5512f70)), closes [#721](#721) * **aws-codecommit:** typo in README ([#780](#780)) ([0e79c2d](0e79c2d)) * **aws-ec2:** Add Burstable Generation 3 Instances ([#812](#812)) ([d36ee6d](d36ee6d)) * **aws-ec2:** fix capitalization of "VPCEndpointType" to "VpcEndpointType" ([#789](#789)) ([7a8ee2c](7a8ee2c)), closes [#765](#765) * **aws-ec2:** fix typo in resource identifier ([#818](#818)) ([f529c80](f529c80)) * **aws-elbv2:** fix load balancer registration ([#890](#890)) ([8cc9abe](8cc9abe)) * **aws-s3:** properly export bucketDomainName ([#844](#844)) ([a65060d](a65060d)) * **aws-sqs:** Queue.import() doesn't return a value ([#885](#885)) ([c592b7f](c592b7f)), closes [#879](#879) * **cdk:** fix TagManager to evaluate to undefined if no tags are included ([#882](#882)) ([477c827](477c827)) * **cdk:** init templates were not upgraded to typescript ^3.0.0 ([#904](#904)) ([2cc7475](2cc7475)) * **cdk:** jsx support conflicts with React usage ([#884](#884)) ([76d8031](76d8031)), closes [#830](#830) * **cfn2ts:** expect Token instead of CloudFormationToken ([#896](#896)) ([6eee1d2](6eee1d2)) * **docs:** fix issue [#718](#718) (Aurora DB example) ([#783](#783)) ([016f3a8](016f3a8)) * **docs:** update supported languages in README ([#819](#819), [#450](#450)) ([#820](#820)) ([ffac98c](ffac98c)) * Correct heading level of CHANGELOG.md 0.10.0 ([40d9ef0](40d9ef0)) * Emit valid YAML-1.1 ([#876](#876)) ([ff857ea](ff857ea)), closes [#875](#875) * **toolkit:** improve error message for large templates ([#900](#900)) ([a41f48f](a41f48f)), closes [#34](#34) Code Refactoring ---------------- * **aws-iam:** move IAM classes cdk to aws-iam ([#866](#866)) ([d46a95b](d46a95b)), closes [#196](#196) * **util:** remove [@aws-cdk](https://github.com/aws-cdk)/util ([#745](#745)) ([10015cb](10015cb)), closes [#709](#709) * **framework:** remove app boilerplate and improvements to cx protocol ([#868](#868)) ([005beec](005beec)), closes [#216](#216) Features -------- * **aws-apigateway:** "LambdaRestApi" and "addProxy" routes ([#867](#867)) ([905a95d](905a95d)) * **aws-cdk:** add maven wrapper to java template ([#811](#811)) ([72aa872](72aa872)) * **aws-cloudformation:** rename the CFN CodePipeline Actions. ([#771](#771)) ([007e7b4](007e7b4)) * **aws-cloudformation:** update the ReadMe of the module to reflect the new Action names. ([#775](#775)) ([6c0e75b](6c0e75b)), closes [#771](#771) * **aws-cloudfront:** Support Security Policy ([#804](#804)) ([b39bf11](b39bf11)), closes [#795](#795) * **aws-codedeploy:** Add the auto-scaling groups property to ServerDeploymentGroup. ([#739](#739)) ([0b28886](0b28886)) * **aws-codedeploy:** Deployment Configuration Construct. ([#653](#653)) ([e6b67ad](e6b67ad)) * **aws-codedeploy:** support setting a load balancer on a Deployment Group. ([#786](#786)) ([e7af9f5](e7af9f5)) * **aws-codepipeline:** allow specifying the runOrder property when creating Actions. ([#776](#776)) ([d146c8d](d146c8d)) * **aws-codepipeline, aws-codecommit, aws-s3:** change the convention for naming the source Actions to XxxSourceAction. ([#753](#753)) ([9c3ce7f](9c3ce7f)) * **aws-dynamodb:** IAM grants support ([#870](#870)) ([c5a4200](c5a4200)) * **aws-dynamodb:** support Global Secondary Indexes ([#760](#760)) ([3601440](3601440)) * **aws-dynamodb:** tags support ([#814](#814)) ([924c84e](924c84e)) * **aws-dynamodB:** support Local Secondary Indexes ([#825](#825)) ([3175af3](3175af3)) * **aws-ec2:** add support for ICMP protocol's classification Types & Codes to SecurityGroupRule ([#893](#893)) ([85bd3c0](85bd3c0)) * **aws-ec2:** allow configuring subnets for NAT gateway ([#874](#874)) ([8ec761c](8ec761c)) * **aws-ec2:** support UDP port ranges in SecurityGroups ([#835](#835)) ([b42ef90](b42ef90)) * **aws-elasticloadbalancingv2:** support for ALB/NLB ([#750](#750)) ([bd9ee01](bd9ee01)) * **aws-s3:** support granting public access to objects ([#886](#886)) ([bdee191](bdee191)), closes [#877](#877) * **cdk:** Add support for UseOnlineResharding with UpdatePolicies ([#881](#881)) ([1f717e1](1f717e1)) * **cdk:** configurable default SSM context provider ([#889](#889)) ([353412b](353412b)) * **core:** resource overrides (escape hatch) ([#784](#784)) ([5054eef](5054eef)), closes [#606](#606) * **aws-codepipeline**: Manage IAM permissions for (some) CFN CodePipeline actions ([#843](#843)) ([4c69118](4c69118)) * **toolkit:** Stop creating 'empty' stacks ([#779](#779)) ([1dddd8a](1dddd8a)) * **aws-autoscaling, aws-ec2:** Tagging support for AutoScaling/SecurityGroup ([#766](#766)) ([3d48eb2](3d48eb2)) ### BREAKING CHANGES * **framework:** The `cdk.App` constructor doesn't accept any arguments, and `app.run()` does not return a `string` anymore. All AWS CDK apps in all languages would need to be modified to adhere to the new API of the `cdk.App` construct. Instead of: const app = new App(process.argv); // ERROR // add stacks process.stdout.write(app.run()); // ERROR The new usage is: const app = new App(); // add stacks app.run(); * **framework:** The CDK is no longer shipped with built-in support for JSX. You can still use JSX but you will have to manually configure it. * **aws-iam:** `PolicyDocument`, `PolicyStatement` and all `PolicyPrincipal` classes moved from the @aws-cdk/cdk module and into the @aws-cdk/aws-iam module. * **aws-codepipeline-api**: `Artifact.subartifact` method of the CodePipeline API was renamed to `Artifact.atPath`. * constructor signature of `TagManager` has changed. `initialTags` is now passed inside a props object. * **util:** @aws-cdk/util is no longer available * **aws-elasticloadbalancingv2:** Adds classes for modeling Application and Network Load Balancers. AutoScalingGroups now implement the interface that makes constructs a load balancing target. The breaking change is that Security Group rule identifiers have been changed in order to make adding rules more reliable. No code changes are necessary but existing deployments may experience unexpected changes. * **aws-cloudformation:** this renames all CloudFormation Actions for CodePipeline to bring them in line with Actions defined in other service packages. * **aws-codepipeline, aws-codecommit, aws-s3:** change the names of the source Actions from XxxSource to XxxSourceAction. This is to align them with the other Actions, like Build. Also, CodeBuild has the concept of Sources, so it makes sense to strongly differentiate between the two.

skinny85 requested a review from eladb September 18, 2018 23:42

skinny85 force-pushed the feature/codedeploy-asg branch from 5859b54 to d72b456 Compare September 19, 2018 00:21

rix0rrr reviewed Sep 19, 2018

View reviewed changes

mindstorms6 reviewed Sep 19, 2018

View reviewed changes

eladb reviewed Sep 19, 2018

View reviewed changes

skinny85 force-pushed the adamruka/codedeploy-deployment-config branch from 30a40da to 6a24ce3 Compare September 20, 2018 01:13

skinny85 force-pushed the feature/codedeploy-asg branch from d72b456 to 816da78 Compare September 20, 2018 01:13

skinny85 commented Sep 20, 2018

View reviewed changes

yubangxi reviewed Sep 20, 2018

View reviewed changes

skinny85 force-pushed the adamruka/codedeploy-deployment-config branch from 6a24ce3 to 16a9b5a Compare September 20, 2018 19:50

skinny85 force-pushed the feature/codedeploy-asg branch from 816da78 to e770a19 Compare September 20, 2018 19:50

eladb reviewed Sep 20, 2018

View reviewed changes

skinny85 force-pushed the feature/codedeploy-asg branch from e770a19 to 0857155 Compare September 20, 2018 20:15

eladb approved these changes Sep 20, 2018

View reviewed changes

skinny85 force-pushed the feature/codedeploy-asg branch from 0857155 to b5e9501 Compare September 20, 2018 23:55

skinny85 changed the base branch from adamruka/codedeploy-deployment-config to master September 20, 2018 23:55

feat(aws-codedeploy): Add the auto-scaling groups property to ServerD…

bedc634

…eploymentGroup.

skinny85 force-pushed the feature/codedeploy-asg branch from b5e9501 to bedc634 Compare September 21, 2018 17:27

skinny85 merged commit 0b28886 into aws:master Sep 21, 2018

skinny85 deleted the feature/codedeploy-asg branch September 21, 2018 18:32

eladb mentioned this pull request Sep 27, 2018

v0.10.0 #800

Merged

NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019

feat(aws-codedeploy): Add the auto-scaling groups property to ServerDeploymentGroup #739

feat(aws-codedeploy): Add the auto-scaling groups property to ServerDeploymentGroup #739

Conversation

skinny85 commented Sep 18, 2018

skinny85 commented Sep 19, 2018

Choose a reason for hiding this comment

rix0rrr Sep 19, 2018 • edited Loading

Choose a reason for hiding this comment

mindstorms6 Sep 19, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

skinny85 Sep 20, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

skinny85 commented Sep 20, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

skinny85 commented Sep 20, 2018

Choose a reason for hiding this comment

skinny85 commented Sep 20, 2018

eladb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

skinny85 commented Sep 21, 2018

rix0rrr Sep 19, 2018 •

edited

Loading

mindstorms6 Sep 19, 2018 •

edited

Loading

skinny85 Sep 20, 2018 •

edited

Loading