Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(@aws-cdk/sns): Convert examples into compiled literate files #107

Merged
merged 4 commits into from
Jun 26, 2018
Merged

docs(@aws-cdk/sns): Convert examples into compiled literate files #107

merged 4 commits into from
Jun 26, 2018

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jun 15, 2018

This is as an initial example of how the mechanism works.

By submitting this pull request, I confirm that my contribution is made under
the terms of the beta license.

eladb
eladb approved these changes Jun 17, 2018
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too awesome!

packages/@aws-cdk/sns/examples/README.md
@@ -0,0 +1,4 @@
The files in this directory cannot actually be compiled, because including their
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the cycle?

Does CodeCommit depend on SNS?

@rix0rrr
Copy link
Contributor Author

rix0rrr commented Jun 17, 2018

Yes

@rix0rrr
Copy link
Contributor Author

rix0rrr commented Jun 17, 2018

Or probably codecommit => events => sns

@eladb
Copy link
Contributor

eladb commented Jun 17, 2018

Or probably codecommit => events => sns

I think events only depends on SNS for testing purposes. I guess the problem is that lerna can discern between devDeps and deps. I have no problem that we have cycles in devDeps.

I think in the meantime we should disable the rejectCycles flag in lerna.json and make sure to introduce our own verification (maybe as part of pkglint) at a later time. It's more important to actually compile the code we have in the repo than maintaining our graph (at this point in time).

@eladb
Copy link
Contributor

eladb commented Jun 20, 2018

@rix0rrr can you follow up on this?

@rix0rrr rix0rrr force-pushed the huijbers/literate-examples branch from f62cd36 to 11cd310 Compare June 20, 2018 14:35
eladb
eladb approved these changes Jun 22, 2018
View reviewed changes
packages/@aws-cdk/sns/test/integ.sns-codecommit-event-rule-target.lit.expected.json Outdated
@@ -1,90 +0,0 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we lose this integration test?

@eladb
Copy link
Contributor

eladb commented Jun 22, 2018

The title of the PR is weird..

@rix0rrr rix0rrr merged commit 5a1d17d into master Jun 26, 2018
@rix0rrr rix0rrr deleted the huijbers/literate-examples branch June 26, 2018 09:03
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rix0rrr @eladb @NGL321