Consider environment variables the AWS CLI considers #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AWS CLI considers `AWS_DEFAULT_PROFILE` and `AWS_DEFAULT_REGION` when creating default clients, however the AWS SDK for JS only considers `AWS_PROFILE` and `AWS_REGION`. This aims to align the behavior of both ways by automatically setting `AWS_PROFILE` and `AWS_REGION` from the matching `AWS_DEFAULT_` variable (unless the variables were already set) See #131
eladb
approved these changes
Jun 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AWS CLI considers
AWS_DEFAULT_PROFILEandAWS_DEFAULT_REGIONwhen creating default clients, however the AWS SDK for JS only considers
AWS_PROFILEandAWS_REGION. This aims to align the behavior of bothways by automatically setting
AWS_PROFILEandAWS_REGIONfrom thematching
AWS_DEFAULT_variable (unless the variables were already set)See #131