Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch to MonoCDK (-experiment) #245

Merged
merged 6 commits into from
Mar 1, 2020
Merged

feat: switch to MonoCDK (-experiment) #245

merged 6 commits into from
Mar 1, 2020

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Feb 13, 2020

Try out the new monocdk to see if it works the way we need it to.

BREAKING CHANGE: to use this version, your application must depend on
monocdk-experiment.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Try out the new monocdk to see if it works the way we need it to.

BREAKING CHANGE: to use this version, your application must depend on
`monocdk-experiment`.
@rix0rrr rix0rrr requested a review from eladb February 13, 2020 14:27
@rix0rrr
Copy link
Contributor Author

rix0rrr commented Feb 13, 2020

Currently doesn't build because:

test/canary.test.ts:19:17 - error TS2345: Argument of type 'Stack' is not assignable to parameter of type 'CloudFormationStackArtifact | Stack'.
  Type 'import("/home/local/ANT/huijbers/Workspaces/PublicCDK/aws-delivlib/node_modules/monocdk-experiment/core/lib/stack").Stack' is not assignable to type 'import("/home/local/ANT/huijbers/Workspaces/PublicCDK/aws-delivlib/node_modules/@aws-cdk/core/lib/stack").Stack'.
    Types of property 'tags' are incompatible.
      Type 'import("/home/local/ANT/huijbers/Workspaces/PublicCDK/aws-delivlib/node_modules/monocdk-experiment/core/lib/tag-manager").TagManager' is not assignable to type 'import("/home/local/ANT/huijbers/Workspaces/PublicCDK/aws-delivlib/node_modules/@aws-cdk/core/lib/tag-manager").TagManager'.
        Types have separate declarations of a private property 'tags'.

19   assert.expect(stack).to(assert.haveResourceLike('AWS::CloudWatch::Alarm', {
                   ~~~~~

@rix0rrr
Copy link
Contributor Author

rix0rrr commented Feb 13, 2020

Conversion has been done with a tool, because who wants to write all that:

https://github.com/rix0rrr/cdk-rewrite-mono-imports

Doesn't win any beauty pageants though, I imagine you all will have things to say about the line wrapping.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: GitHubPipelineAutoBuildProj-eNGjrh4O6eRH
  • Commit ID: 9bdc2a7
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@eladb
Copy link
Contributor

eladb commented Feb 13, 2020

https://github.com/rix0rrr/cdk-rewrite-mono-imports

👍 👍 👍 added to mono-package RFC

Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like it that this literally almost didn't include any code change.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: GitHubPipelineAutoBuildProj-eNGjrh4O6eRH
  • Commit ID: a8fc11f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: GitHubPipelineAutoBuildProj-eNGjrh4O6eRH
  • Commit ID: 703afed
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: GitHubPipelineAutoBuildProj-eNGjrh4O6eRH
  • Commit ID: ae2b619
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: GitHubPipelineAutoBuildProj-eNGjrh4O6eRH
  • Commit ID: 7b32be5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@eladb eladb merged commit f0863de into master Mar 1, 2020
@eladb eladb deleted the huijbers/monocdk branch March 1, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants