-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: switch to MonoCDK (-experiment) #245
Conversation
Try out the new monocdk to see if it works the way we need it to. BREAKING CHANGE: to use this version, your application must depend on `monocdk-experiment`.
Currently doesn't build because:
|
Conversion has been done with a tool, because who wants to write all that: https://github.com/rix0rrr/cdk-rewrite-mono-imports Doesn't win any beauty pageants though, I imagine you all will have things to say about the line wrapping. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
👍 👍 👍 added to mono-package RFC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I like it that this literally almost didn't include any code change.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Try out the new monocdk to see if it works the way we need it to.
BREAKING CHANGE: to use this version, your application must depend on
monocdk-experiment
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.