Skip to content

Commit 90387b7

Browse files
committed
Remaining PR feedback
1 parent e2d529f commit 90387b7

File tree

1 file changed

+7
-7
lines changed
  • changes/2020-07-14_multi-keyring-require-generation

1 file changed

+7
-7
lines changed

changes/2020-07-14_multi-keyring-require-generation/change.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,10 @@ is [tracked separately](https://github.com/awslabs/aws-encryption-sdk-specificat
6060

6161
If we do not make a guarantee that the generator will generate,
6262
then its usefulness is limited.
63-
Customers may have a compliance requirement that all data keys MUST be generated by a specific HSM,
64-
or may want to lock down true least-privilege permissions for their AWS KMS key policies.
63+
Customers might have a compliance requirement that all data keys MUST be generated by a specific HSM,
64+
or might want to lock down true least-privilege permissions for their AWS KMS key policies.
6565
Under the current model,
66-
customers have to be very careful to make sure that they know
66+
users have to be very careful to make sure that they know
6767
exactly where and how a given multi-keyring configuration is being used
6868
rather than being certain that it will always do the same thing no matter what.
6969

@@ -78,10 +78,10 @@ between security and usability.
7878

7979
## Security Implications
8080

81-
Removing this flexibility may help identify potential security issues,
82-
as customers may discover when upgrading their ESDK version
81+
Removing this flexibility might help identify potential security issues,
82+
as users might discover when upgrading their ESDK version
8383
that data keys are not being generated as intended.
84-
Correcting this will allow customers
84+
Correcting this will in turn provide the opportunity
8585
to improve their security postures
8686
through improvements such as scoping down permissions.
8787

@@ -95,7 +95,7 @@ but SHOULD also reduce troubleshooting requests
9595
related to unexpected behaviour around data key generation,
9696
or unexpected permissions errors due to the same.
9797

98-
## Guide-level Explanation
98+
## Guide-level/Reference-level Explanation
9999

100100
The description of OnEncrypt for the multi-keyring
101101
will be changed to read as follows:

0 commit comments

Comments
 (0)