-
Notifications
You must be signed in to change notification settings - Fork 421
fix(logger): clear_state should keep custom key formats #1095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(logger): clear_state should keep custom key formats #1095
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
Codecov Report
@@ Coverage Diff @@
## develop #1095 +/- ##
========================================
Coverage 99.96% 99.96%
========================================
Files 119 119
Lines 5377 5377
Branches 613 613
========================================
Hits 5375 5375
Partials 2 2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one suggestion on tests so we reduce the use of regex to improve test perf and ease future maintenance for the untrained eye.
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Issue #, if available: #1084
Description of changes:
When using
clear_state=True
, overriden formats for standard logging keys likelocation
andtimestamp
was being overriden with the default formats. Overriding the formats are explained in the docs like this:Issue was that when
clear_state=True
was used, the default keys were reset to their defaults (by the fix implemented in #1088). This fix saves the formatting keys on instantiation and uses those instead whenclear_state
is called.Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.