Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): use gh environment for beta and prod layer deploy #1356

Merged
merged 1 commit into from
Jul 22, 2022
Merged

chore(ci): use gh environment for beta and prod layer deploy #1356

merged 1 commit into from
Jul 22, 2022

Conversation

am29d
Copy link
Contributor

@am29d am29d commented Jul 22, 2022

Issue number: #1354

Summary

Add layer specific environment in GitHub so we can use account specific secrets without passing the role name.

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@am29d am29d requested review from a team as code owners July 22, 2022 14:42
@am29d am29d requested review from sthulb and removed request for a team July 22, 2022 14:42
@boring-cyborg boring-cyborg bot added the github-actions Pull requests that update Github_actions code label Jul 22, 2022
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 22, 2022
@github-actions github-actions bot added the internal Maintenance changes label Jul 22, 2022
@heitorlessa heitorlessa changed the title chore(ci): use environment for beta and prod deploy chore(ci): use gh environment for beta and prod layer deploy Jul 22, 2022
@heitorlessa heitorlessa merged commit bbceb4a into aws-powertools:develop Jul 22, 2022
heitorlessa added a commit to heitorlessa/aws-lambda-powertools-python that referenced this pull request Jul 22, 2022
…tools-python into develop

* 'develop' of https://github.com/awslabs/aws-lambda-powertools-python:
  chore(ci): use gh environment for beta and prod layer deploy (aws-powertools#1356)
  chore(ci): remove core group from codeowners (aws-powertools#1358)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update Github_actions code internal Maintenance changes size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants