Skip to content

fix(event_sources): add test for Function URL AuthZ #1421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rubenfonseca
Copy link
Contributor

Issue number: #1416

Summary

Changes

Please provide a summary of what's being changed

Function URL latest introduction is missing a test without authorization fields. This PR ensures code paths work when a function URL is configured as NONE for AuthType.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 5, 2022
@github-actions github-actions bot added the bug Something isn't working label Aug 5, 2022
@rubenfonseca rubenfonseca marked this pull request as ready for review August 5, 2022 10:17
@rubenfonseca rubenfonseca requested a review from a team as a code owner August 5, 2022 10:17
@rubenfonseca rubenfonseca requested review from mploski and heitorlessa and removed request for a team August 5, 2022 10:17
@heitorlessa heitorlessa changed the title fix(event_sources): add test for Function URL AuthZ chore(event_sources): add test for Function URL AuthZ Aug 5, 2022
@heitorlessa heitorlessa changed the title chore(event_sources): add test for Function URL AuthZ fix(event_sources): add test for Function URL AuthZ Aug 5, 2022
@github-actions github-actions bot added the internal Maintenance changes label Aug 5, 2022
@heitorlessa
Copy link
Contributor

thank you so much @rubenfonseca! merging

@heitorlessa heitorlessa merged commit 3ed48e7 into aws-powertools:develop Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal Maintenance changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tests utilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants