Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jmespath_util): snappy as dev dep and typing example #1446

Conversation

leandrodamascena
Copy link
Contributor

@leandrodamascena leandrodamascena commented Aug 11, 2022

Issue number: #1443

Summary

Changes

Fixing problems when running make pr

User experience

before:
image

After:
image

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner August 11, 2022 17:01
@leandrodamascena leandrodamascena requested review from am29d and removed request for a team August 11, 2022 17:01
@boring-cyborg boring-cyborg bot added area/utilities dependencies Pull requests that update a dependency file labels Aug 11, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 11, 2022
@github-actions github-actions bot added the bug Something isn't working label Aug 11, 2022
@leandrodamascena leandrodamascena changed the title fix(examples): Fixing problems in jmespath_utils example fix(dev): Fixing mypy typing and dev dependencies in the examples files Aug 11, 2022
@heitorlessa heitorlessa changed the title fix(dev): Fixing mypy typing and dev dependencies in the examples files fix(jmespath_util): snappy mypy typing and Aug 11, 2022
@heitorlessa heitorlessa changed the title fix(jmespath_util): snappy mypy typing and fix(jmespath_util): snappy as dev dep and mypy typing and Aug 11, 2022
@heitorlessa heitorlessa changed the title fix(jmespath_util): snappy as dev dep and mypy typing and fix(jmespath_util): snappy as dev dep and mypy typing Aug 11, 2022
@heitorlessa heitorlessa changed the title fix(jmespath_util): snappy as dev dep and mypy typing fix(jmespath_util): snappy as dev dep and typing example Aug 11, 2022
@heitorlessa heitorlessa merged commit 18a3c55 into aws-powertools:develop Aug 11, 2022
heitorlessa added a commit to heitorlessa/aws-lambda-powertools-python that referenced this pull request Aug 12, 2022
* develop:
  chore(deps-dev): bump types-requests from 2.28.7 to 2.28.8 (aws-powertools#1423)
  chore(ci): update changelog with latest changes
  fix(jmespath_util): snappy as dev dep and typing example (aws-powertools#1446)

Signed-off-by: heitorlessa <lessa@amazon.co.uk>
heitorlessa pushed a commit to heitorlessa/aws-lambda-powertools-python that referenced this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants