-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): add linter for GitHub Actions as pre-commit hook #1479
Merged
leandrodamascena
merged 6 commits into
aws-powertools:develop
from
heitorlessa:chore/add-github-actions-linter
Aug 25, 2022
Merged
chore(ci): add linter for GitHub Actions as pre-commit hook #1479
leandrodamascena
merged 6 commits into
aws-powertools:develop
from
heitorlessa:chore/add-github-actions-linter
Aug 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
github-actions
Pull requests that update Github_actions code
internal
Maintenance changes
labels
Aug 25, 2022
pull-request-size
bot
added
the
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Aug 25, 2022
heitorlessa
requested review from
leandrodamascena,
am29d and
rubenfonseca
and removed request for
am29d
August 25, 2022 16:03
heitorlessa
added a commit
to heitorlessa/aws-lambda-powertools-python
that referenced
this pull request
Aug 25, 2022
…tools-python into develop * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: chore(ci): add linter for GitHub Actions as pre-commit hook (aws-powertools#1479) Signed-off-by: heitorlessa <lessa@amazon.co.uk>
heitorlessa
added a commit
to heitorlessa/aws-lambda-powertools-python
that referenced
this pull request
Aug 25, 2022
* develop: chore(ci): add linter for GitHub Actions as pre-commit hook (aws-powertools#1479)
rubenfonseca
pushed a commit
that referenced
this pull request
Sep 13, 2022
Tankanow
pushed a commit
to Tankanow/aws-lambda-powertools-python
that referenced
this pull request
Sep 13, 2022
Tankanow
pushed a commit
to Tankanow/aws-lambda-powertools-python
that referenced
this pull request
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
github-actions
Pull requests that update Github_actions code
internal
Maintenance changes
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #1332
Summary
Changes
This introduces Action Lint as a pre-commit hook to catch unforeseen syntax errors to prevent future failures.
It also includes fixes for all issues caught: key but optional fields missing, dangling debug step, and incorrect syntax for new changelog adhoc workflow
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.