Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add linter for GitHub Actions as pre-commit hook #1479

Conversation

heitorlessa
Copy link
Contributor

Issue number: #1332

Summary

Changes

Please provide a summary of what's being changed

This introduces Action Lint as a pre-commit hook to catch unforeseen syntax errors to prevent future failures.

It also includes fixes for all issues caught: key but optional fields missing, dangling debug step, and incorrect syntax for new changelog adhoc workflow

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@heitorlessa heitorlessa requested a review from a team as a code owner August 25, 2022 16:03
@heitorlessa heitorlessa requested review from am29d and removed request for a team August 25, 2022 16:03
@boring-cyborg boring-cyborg bot added github-actions Pull requests that update Github_actions code internal Maintenance changes labels Aug 25, 2022
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 25, 2022
@heitorlessa heitorlessa requested review from leandrodamascena, am29d and rubenfonseca and removed request for am29d August 25, 2022 16:03
@leandrodamascena leandrodamascena merged commit becb38c into aws-powertools:develop Aug 25, 2022
heitorlessa added a commit to heitorlessa/aws-lambda-powertools-python that referenced this pull request Aug 25, 2022
…tools-python into develop

* 'develop' of https://github.com/awslabs/aws-lambda-powertools-python:
  chore(ci): add linter for GitHub Actions as pre-commit hook (aws-powertools#1479)

Signed-off-by: heitorlessa <lessa@amazon.co.uk>
heitorlessa added a commit to heitorlessa/aws-lambda-powertools-python that referenced this pull request Aug 25, 2022
* develop:
  chore(ci): add linter for GitHub Actions as pre-commit hook (aws-powertools#1479)
Tankanow pushed a commit to Tankanow/aws-lambda-powertools-python that referenced this pull request Sep 13, 2022
Tankanow pushed a commit to Tankanow/aws-lambda-powertools-python that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update Github_actions code internal Maintenance changes size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants