-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(data-classes): add KafkaEvent and KafkaEventRecord #1485
feat(data-classes): add KafkaEvent and KafkaEventRecord #1485
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
Hi @lyoung-confluent! Indeed this is an awesome PR! Thanks a lot for taking the time to help improve the project! 🥇 I'm going to start doing a review on this PR today and let you know if we need to make some small changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @lyoung-confluent! I suggested some changes in this PR.
Codecov Report
@@ Coverage Diff @@
## develop #1485 +/- ##
===========================================
- Coverage 99.89% 99.48% -0.41%
===========================================
Files 124 126 +2
Lines 5588 5672 +84
Branches 634 661 +27
===========================================
+ Hits 5582 5643 +61
- Misses 2 14 +12
- Partials 4 15 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Hey @lyoung-confluent. I split the tests into 2 to make it clearer what is being tested and added 1 more field to test the bootstrapserver as a raw string. I think it's good for me to merge. Do you have any more considerations? 🚀 |
Looks good to me, thanks for the quick feedback/review @leandrodamascena! |
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
* develop: chore(deps-dev): bump aws-cdk-lib from 2.40.0 to 2.41.0 (#1507) update changelog with latest changes feat(tracer): support methods with the same name (ABCs) by including fully qualified name in v2 (#1486) chore(deps-dev): bump aws-cdk-aws-apigatewayv2-integrations-alpha from 2.39.1a0 to 2.40.0a0 (#1496) chore(deps-dev): bump mkdocs-material from 8.4.2 to 8.4.3 (#1504) chore(deps): bump pydantic from 1.10.1 to 1.10.2 (#1502) update changelog with latest changes feat(data-classes): add KafkaEvent and KafkaEventRecord (#1485) chore(deps-dev): bump pytest from 7.1.2 to 7.1.3 (#1497) update changelog with latest changes feat(event_handler): add cookies as 1st class citizen in v2 (#1487) chore(deps-dev): bump black from 22.6.0 to 22.8.0 (#1494) chore(deps-dev): bump aws-cdk-lib from 2.39.1 to 2.40.0 (#1495) chore(maintenance): add discord link to first PR and first issue (#1493) update changelog with latest changes refactor(batch): remove legacy sqs_batch_processor (#1492) chore(deps): bump pydantic from 1.10.0 to 1.10.1 (#1491) chore(deps-dev): bump flake8-variables-names from 0.0.4 to 0.0.5 (#1490)
Co-authored-by: Leandro Damascena <leandro.damascena@gmail.com>
Issue number: #1484
Summary
This change adds a data class for Kafka event sources either from self-managed Apache Kafka or Amazon MSK.
Changes
A new data class
KafkaEvent
is introduced which includes arecords
property/generator. The returnedKafkaEventRecord
class has a variety of useful properties for decoding the record key, value and headers.User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
Not a breaking change
RFC issue number: ?
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.
View rendered docs/utilities/data_classes.md