refactor(batch): remove legacy sqs_batch_processor in v2 #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
documentation
pull-request-size
bot
added
the
size/XL
pull-request-size
bot
added
size/XXL
|
1 similar comment
|
rubenfonseca
requested review from
am29d and
heitorlessa
and removed request for
a team and
am29d
Codecov Report
@@ Coverage Diff @@
## v2 #1492 +/- ##
==========================================
+ Coverage 99.85% 99.90% +0.05%
==========================================
Files 125 124 -1
Lines 5644 5554 -90
Branches 651 641 -10
==========================================
- Hits 5636 5549 -87
+ Misses 3 1 -2
+ Partials 5 4 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
heitorlessa
approved these changes
Sep 1, 2022
heitorlessa
changed the title
heitorlessa
changed the title
heitorlessa
changed the title
heitorlessa
added a commit
that referenced
this pull request
Sep 9, 2022
* develop: chore(deps-dev): bump aws-cdk-lib from 2.40.0 to 2.41.0 (#1507) update changelog with latest changes feat(tracer): support methods with the same name (ABCs) by including fully qualified name in v2 (#1486) chore(deps-dev): bump aws-cdk-aws-apigatewayv2-integrations-alpha from 2.39.1a0 to 2.40.0a0 (#1496) chore(deps-dev): bump mkdocs-material from 8.4.2 to 8.4.3 (#1504) chore(deps): bump pydantic from 1.10.1 to 1.10.2 (#1502) update changelog with latest changes feat(data-classes): add KafkaEvent and KafkaEventRecord (#1485) chore(deps-dev): bump pytest from 7.1.2 to 7.1.3 (#1497) update changelog with latest changes feat(event_handler): add cookies as 1st class citizen in v2 (#1487) chore(deps-dev): bump black from 22.6.0 to 22.8.0 (#1494) chore(deps-dev): bump aws-cdk-lib from 2.39.1 to 2.40.0 (#1495) chore(maintenance): add discord link to first PR and first issue (#1493) update changelog with latest changes refactor(batch): remove legacy sqs_batch_processor (#1492) chore(deps): bump pydantic from 1.10.0 to 1.10.1 (#1491) chore(deps-dev): bump flake8-variables-names from 0.0.4 to 0.0.5 (#1490)
Tankanow
pushed a commit
to Tankanow/aws-lambda-powertools-python
that referenced
this pull request
Sep 13, 2022
Tankanow
pushed a commit
to Tankanow/aws-lambda-powertools-python
that referenced
this pull request
Sep 13, 2022
rubenfonseca
added a commit
that referenced
this pull request
Sep 14, 2022
rubenfonseca
added a commit
that referenced
this pull request
Oct 14, 2022
|
resolves #1462 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #1462
Summary
This PR removes the legacy SQS batch implementation.
Changes
Code was removed, as well as lot of old tests. Documentation was updated to not reference the SQS batch implementation.
The migration guide was also updated to include the old migration guide.
User experience
After this change, a user has to use the native
BatchProcessorclass or thebatch_processordecorator.Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.
View rendered docs/utilities/batch.md