-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Metrics middleware using CloudWatch EMF #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sthulb
approved these changes
Apr 8, 2020
jfuss
reviewed
Apr 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test that producing the whl/sdist with poetry build
still included all the files you need (for example is the .json files included correctly in the package)?
@marcioemiranda What are your thoughts? I know you're using the lib extensively |
7 tasks
heitorlessa
changed the title
Feature - EMF Metrics middleware
feat: add Metrics middleware using CloudWatch EMF
Jun 3, 2020
heitorlessa
referenced
this pull request
in heitorlessa/aws-lambda-powertools-python
Jun 17, 2020
* feat: add metrics middleware * fix(Makefile): increase verbosity for test results * chore: linting * chore: add deprecation warning log_metric * docs: add initial docs for metrics * chore: version bump * fix: replace jsonschema, automate wheels for Linux * feat: add docs generation * feat(Makefile): add docs target * docs: update to reflect metrics middleware, beta * docs: update history * improv(metrics): address feedbacks from Jacob * fix(metrics): correct decorator logic * chore: version bump * fix(Makefile): fix build linux wheels target * fix(metrics): lambda handler return and exceptions * chore: version bump * improv: update example to use new metrics feat Co-authored-by: heitorlessa <lessa@amazon.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #1
Description of changes:
log_metric
to ensure it raises deprecation errorlog_metric
Features
UX
Multiple metrics
Used alongside other middlewares that call the decorated function
Single metric feature
Context manager with parameters using similar DX as multiple metrics
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.