Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): document optional dependencies and local dev #1574

Merged
merged 12 commits into from
Oct 7, 2022

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Oct 7, 2022

Issue number: #1573

Summary

Changes

Please provide a summary of what's being changed

Documents optional dependencies customers will have to install for certain utilities (Tracer, Parser, Validation). It also adds a new section under Install to cover AWS SDK being a dev dependency, and when it's not necessary (SAM CLI invoke).

User experience

Please share what the user experience looks like before and after this change

image

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.


View rendered README.md
View rendered docs/index.md

@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Oct 7, 2022
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 7, 2022
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 7, 2022
@pull-request-size pull-request-size bot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 7, 2022
@boring-cyborg boring-cyborg bot added dependencies Pull requests that update a dependency file github-actions Pull requests that update Github_actions code internal Maintenance changes tests labels Oct 7, 2022
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 7, 2022
heitorlessa and others added 5 commits October 7, 2022 16:07
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
@heitorlessa heitorlessa marked this pull request as ready for review October 7, 2022 14:21
@heitorlessa heitorlessa requested a review from a team as a code owner October 7, 2022 14:21
@heitorlessa heitorlessa requested review from am29d and removed request for a team October 7, 2022 14:21
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 7, 2022
@heitorlessa heitorlessa requested review from rubenfonseca and removed request for am29d October 7, 2022 14:21
@heitorlessa heitorlessa linked an issue Oct 7, 2022 that may be closed by this pull request
6 tasks
@codecov-commenter
Copy link

Codecov Report

Base: 99.42% // Head: 99.42% // No change to project coverage 👍

Coverage data is based on head (7cb52d3) compared to base (2e5d0cb).
Patch has no changes to coverable lines.

❗ Current head 7cb52d3 differs from pull request most recent head 03ea0c9. Consider uploading reports for the commit 03ea0c9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##               v2    #1574   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files         125      125           
  Lines        5726     5726           
  Branches      357      357           
=======================================
  Hits         5693     5693           
  Misses         18       18           
  Partials       15       15           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@rubenfonseca rubenfonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements, thank you Heitor!

@heitorlessa heitorlessa merged commit e9741bb into aws-powertools:v2 Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation github-actions Pull requests that update Github_actions code internal Maintenance changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Update docs for v2
3 participants