-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(apigateway): support nested router decorators #1709
fix(apigateway): support nested router decorators #1709
Conversation
Hi @kt-hr could you create a feature request for this? We'd happily accept your PR after that, since this isn't a bug nor related to the exception handler. Thanks a lot! |
Hi @heitorlessa , Thanks for commenting. I will create a feature request. I thought it was a bug based on the difference in behavior between |
You're right @kt-hr. It's a bug as the legacy Thank you! |
I'll create a quick maintenance issue for that discrepancy, then merge this PR. Hang tight |
made a tiny change on test comments only. Thanks a lot for providing tests upfront, much appreciated! Merging. |
Issue number: #1712
Summary
Changes
This PR fixes a bug router decorator cannot be nested.
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.