Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(logger): Add warning of uncaught exceptions #1826

Merged
merged 1 commit into from
Jan 10, 2023
Merged

docs(logger): Add warning of uncaught exceptions #1826

merged 1 commit into from
Jan 10, 2023

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #1825

Summary

Changes

Update Uncaught exceptions documentation

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner January 10, 2023 16:11
@leandrodamascena leandrodamascena requested review from rubenfonseca and removed request for a team January 10, 2023 16:11
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Jan 10, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 10, 2023
@leandrodamascena leandrodamascena changed the title docs(logger): Adding warning about using uncaught logs docs(logger): Adding warning uncaught logs documentation Jan 10, 2023
@leandrodamascena leandrodamascena changed the title docs(logger): Adding warning uncaught logs documentation docs(logger): Add warning of uncaught exceptions Jan 10, 2023
@leandrodamascena leandrodamascena merged commit 52b7787 into aws-powertools:develop Jan 10, 2023
@leandrodamascena leandrodamascena deleted the docs/fix-logger branch January 10, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenfonseca rubenfonseca rubenfonseca approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leandrodamascena @rubenfonseca