Skip to content

fix(lint): Move tests/THIRD-PARTY-LICENSES to root #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2021

Conversation

michaelbrewer
Copy link
Contributor

@michaelbrewer michaelbrewer commented Mar 20, 2021

Issue #, if available:

Description of changes:

Move tests/THIRD-PARTY-LICENSES to the correct location

Side effect was that it was breaking the linting :)

⋊> ~/p/p/aws-lambda-powertools-python on fix-flake8 ⨯ make lint                                                                                                              poetry run isort -rc aws_lambda_powertools tests
poetry run black aws_lambda_powertools tests
All done! ✨ 🍰 ✨
139 files left unchanged.
poetry run flake8 aws_lambda_powertools/* tests/*
tests/THIRD-PARTY-LICENSES:1:1: E902 IndentationError: unindent does not match any outer indentation level
tests/THIRD-PARTY-LICENSES:1:22: E231 missing whitespace after ':'
tests/THIRD-PARTY-LICENSES:1:23: E226 missing whitespace around arithmetic operator
tests/THIRD-PARTY-LICENSES:1:35: E226 missing whitespace around arithmetic operator
tests/THIRD-PARTY-LICENSES:1:46: E226 missing whitespace around arithmetic operator
tests/THIRD-PARTY-LICENSES:3:34: E111 indentation is not a multiple of four
tests/THIRD-PARTY-LICENSES:3:34: E113 unexpected indentation
make: *** [lint] Error 1

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@michaelbrewer michaelbrewer changed the title fix(lint): Exclude tests/THIRD-PARTY-LICENSES fix(lint): Exclude tests/THIRD-PARTY-LICENSES Mar 20, 2021
@michaelbrewer
Copy link
Contributor Author

@heitorlessa i think this will fix it.

@heitorlessa
Copy link
Contributor

If it's not too much to ask, could you update the PR by simply moving this Third party license file to the root of the project?

I accidentally created in the wrong place and quickly before I left home. There's no need to exclude it from tests

@michaelbrewer
Copy link
Contributor Author

If it's not too much to ask, could you update the PR by simply moving this Third party license file to the root of the project?

I accidentally created in the wrong place and quickly before I left home. There's no need to exclude it from tests

sure. I see what you mean :)

@michaelbrewer michaelbrewer changed the title fix(lint): Exclude tests/THIRD-PARTY-LICENSES fix(lint): Move tests/THIRD-PARTY-LICENSES to root Mar 20, 2021
@michaelbrewer
Copy link
Contributor Author

@heitorlessa done

@heitorlessa heitorlessa added the internal Maintenance changes label Mar 20, 2021
@heitorlessa
Copy link
Contributor

Thank you!! Lesson learned to not make any changes in a rush or use the phone to review stuff

@heitorlessa heitorlessa merged commit 961b25e into aws-powertools:develop Mar 20, 2021
@michaelbrewer michaelbrewer deleted the fix-flake8 branch March 20, 2021 18:24
mergify bot pushed a commit that referenced this pull request Aug 16, 2021
Bumps [flake8-comprehensions](https://github.com/adamchainz/flake8-comprehensions) from 3.6.0 to 3.6.1.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/adamchainz/flake8-comprehensions/blob/main/HISTORY.rst">flake8-comprehensions's changelog</a>.</em></p>
<blockquote>
<h2>3.6.1 (2021-08-16)</h2>
<ul>
<li>
<p>Fix type hint for <code>tree</code> argument.</p>
<p>Thanks to kasium for the report in <code>Issue [#352](adamchainz/flake8-comprehensions#352) &lt;https://github.com/adamchainz/flake8-comprehensions/issues/352&gt;</code>__.</p>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/adamchainz/flake8-comprehensions/commit/c6d802b588f92c674a88fb234baa850cd028e4d9"><code>c6d802b</code></a> Version 3.6.1</li>
<li><a href="https://github.com/adamchainz/flake8-comprehensions/commit/a67afde4100ebfafe0f24bef2251c2b1050a25bf"><code>a67afde</code></a> Fix type for tree argument (<a href="https://github-redirect.dependabot.com/adamchainz/flake8-comprehensions/issues/353">#353</a>)</li>
<li><a href="https://github.com/adamchainz/flake8-comprehensions/commit/817f61bb89d691b442b04a38eeab49aa0a68f9b7"><code>817f61b</code></a> Upgrade requirements (<a href="https://github-redirect.dependabot.com/adamchainz/flake8-comprehensions/issues/351">#351</a>)</li>
<li><a href="https://github.com/adamchainz/flake8-comprehensions/commit/3d7f44372a896178117e082d458fb358b3a7f4a5"><code>3d7f443</code></a> Add flake8 version to issue form (<a href="https://github-redirect.dependabot.com/adamchainz/flake8-comprehensions/issues/350">#350</a>)</li>
<li>See full diff in <a href="https://github.com/adamchainz/flake8-comprehensions/compare/3.6.0...3.6.1">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=flake8-comprehensions&package-manager=pip&previous-version=3.6.0&new-version=3.6.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants