refactor(event-handler): Add ResponseBuilder and more docs #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change: - Add new ResponseBuilder to replace the Tuple[Route, Response] - Refactor code to be easier to maintain
|
@heitorlessa did some refactoring of the |
Codecov Report
@@ Coverage Diff @@
## develop #412 +/- ##
========================================
Coverage 99.89% 99.89%
========================================
Files 101 101
Lines 3967 3976 +9
Branches 198 198
========================================
+ Hits 3963 3972 +9
Misses 1 1
Partials 3 3
Continue to review full report at Codecov.
|
heitorlessa
reviewed
Apr 29, 2021
| Response( | ||
| status_code=404, | ||
| content_type="application/json", | ||
| body=json.dumps({"message": f"No route found for '{method}.{path}'"}), |
There was a problem hiding this comment.
Note to self: Pull the entire code to check whether we're not making customers vulnerable to data enumeration attacks via HTTP status code
michaelbrewer
changed the title
|
@heitorlessa do you want me to add anything else to this? |
heitorlessa
approved these changes
May 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Change:
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.