-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tracer): add service annotation when service is set #861
Merged
heitorlessa
merged 4 commits into
aws-powertools:develop
from
heitorlessa:feat/tracer-service-annotation
Nov 30, 2021
Merged
feat(tracer): add service annotation when service is set #861
heitorlessa
merged 4 commits into
aws-powertools:develop
from
heitorlessa:feat/tracer-service-annotation
Nov 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area/tracer
documentation
Improvements or additions to documentation
internal
Maintenance changes
tests
labels
Nov 30, 2021
pull-request-size
bot
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
Nov 30, 2021
Codecov Report
@@ Coverage Diff @@
## develop #861 +/- ##
========================================
Coverage 99.90% 99.90%
========================================
Files 118 118
Lines 5110 5125 +15
Branches 280 283 +3
========================================
+ Hits 5105 5120 +15
Misses 2 2
Partials 3 3
Continue to review full report at Codecov.
|
4 tasks
12 tasks
@heitorlessa - don't miss this in the changelog, a super cool improvement |
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
feature
New feature or functionality
internal
Maintenance changes
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #850
Description of changes:
When setting
service
parameter orPOWERTOOLS_SERVICE_NAME
, Tracer will add a new annotation namedService
to ease filtering a given component by service. Often times, this is used to create more meaningful X-Ray Trace Groups for larger applications.Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
View rendered docs/core/tracer.md