Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid body panics the runtime #517

Closed
m-ronchi opened this issue Aug 29, 2022 · 3 comments · Fixed by #520
Closed

Invalid body panics the runtime #517

m-ronchi opened this issue Aug 29, 2022 · 3 comments · Fixed by #520
Labels
help wanted Extra attention is needed

Comments

@m-ronchi
Copy link

this line makes the process exit with status 1 when the request body is malformed (e.g. there are missing fields).

it should instead send back an EventErrorRequest with the appropriate error details and continue processing

@calavera
Copy link
Contributor

it sounds reasonable, do you want to open a PR?

@calavera calavera added the help wanted Extra attention is needed label Aug 29, 2022
@m-ronchi
Copy link
Author

I tried, but I am not familiar with rust yet and I couldn't make a unit test for it (tried to adapt this but it's pretty complex...)

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for the maintainers of this repository to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants