Make child-spans work as expected when using the lambda-runtime #896
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes: Implementing a sub-span directly in the
service_fn
does not currently set the parent-span in the expected way. Example:The problem is, that at the time where the
create_event_span()
function is called, the span returned byrequest_span()
has not been entered, so it will be not be set as the parent.The solution is to enter the span before calling the inner service. This also matches e.g. how
tower_http
does it.By submitting this pull request