Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from Reqwest client to Hyper client #54

Closed
bnusunny opened this issue Jul 24, 2022 · 1 comment
Closed

Switch from Reqwest client to Hyper client #54

bnusunny opened this issue Jul 24, 2022 · 1 comment

Comments

@bnusunny
Copy link
Contributor

bnusunny commented Jul 24, 2022 •
edited
Loading

Lambda Web Adapter use Reqwest client to send http requests, which works great. And AWS Lambda Rust Runtime lambda-http crate added support for http_body::Body in v0.6.0, see PR#491.

By switching from Reqwest client to Hyper client, we can use that feature from lambda-http crate and remove convert_body() function here. Reduce the amount of code in the adapter.
@bnusunny bnusunny changed the title switch from Reqwest client to Hyper client Switch from Reqwest client to Hyper client Jul 24, 2022
@bnusunny
Copy link
Contributor Author

Close this one because we built a tower service and cannot leverage lambda-http PR#491.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bnusunny