Transform config credential keys (#661)

Author: trivikr

.changeset/itchy-pets-remain.md

@@ -0,0 +1,5 @@
+---
+"aws-sdk-js-codemod": patch
+---
+
+Transform config credential keys

src/transforms/v2-to-v3/__fixtures__/config/accessKeyId.input.js

@@ -0,0 +1,6 @@
+import AWS from "aws-sdk";
+
+const client = new AWS.DynamoDB({
+  accessKeyId: "KEY",
+  secretAccessKey: "SECRET"
+});

src/transforms/v2-to-v3/__fixtures__/config/accessKeyId.output.js

@@ -0,0 +1,8 @@
+import { DynamoDB } from "@aws-sdk/client-dynamodb";
+
+const client = new DynamoDB({
+  credentials: {
+    accessKeyId: "KEY",
+    secretAccessKey: "SECRET"
+  }
+});

src/transforms/v2-to-v3/client-instances/getObjectWithUpdatedAwsConfigKeys.ts

@@ -16,9 +16,12 @@ const getCodemodUnsuppportedComments = (keyName: string) => [
 export const getObjectWithUpdatedAwsConfigKeys = (
   j: JSCodeshift,
   objectExpression: ObjectExpression
-) =>
-  j.objectExpression(
-    objectExpression.properties.map((property) => {
+) => {
+  const securityCredentialKeys = ["accessKeyId", "secretAccessKey", "sessionToken"];
+  const credentials = j.objectExpression([]);
+
+  const updatedProperties = objectExpression.properties
+    .map((property) => {
       if (!OBJECT_PROPERTY_TYPE_LIST.includes(property.type)) {
         return property;
       }
@@ -28,6 +31,11 @@ export const getObjectWithUpdatedAwsConfigKeys = (
         return property;
       }
 
+      if (securityCredentialKeys.includes(propertyKey.name)) {
+        credentials.properties.push(property);
+        return undefined;
+      }
+
       const awsConfigKeyStatus = AWS_CONFIG_KEY_MAP[propertyKey.name];
 
       if (!awsConfigKeyStatus) {
@@ -63,4 +71,13 @@ export const getObjectWithUpdatedAwsConfigKeys = (
 
       return property;
     })
-  );
+    .filter((property) => property !== undefined);
+
+  if (credentials.properties.length > 0) {
+    updatedProperties.unshift(j.objectProperty(j.identifier("credentials"), credentials));
+  }
+
+  // eslint-disable-next-line @typescript-eslint/ban-ts-comment
+  // @ts-ignore is Argument is not assignable to parameter
+  return j.objectExpression(updatedProperties);
+};

src/transforms/v2-to-v3/client-instances/replaceAwsConfig.ts

@@ -12,14 +12,8 @@ export const replaceAwsConfig = (
     .find(j.NewExpression, {
       callee: {
         type: "MemberExpression",
-        object: {
-          type: "Identifier",
-          name: v2GlobalName,
-        },
-        property: {
-          type: "Identifier",
-          name: "Config",
-        },
+        object: { type: "Identifier", name: v2GlobalName },
+        property: { type: "Identifier", name: "Config" },
       },
     })
     .filter(