Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc versioning for features and overall min req. Sample smithy-http. #129

Closed
johnsoncarlp opened this issue Jun 23, 2021 · 1 comment · Fixed by #130
Closed

rustc versioning for features and overall min req. Sample smithy-http. #129

johnsoncarlp opened this issue Jun 23, 2021 · 1 comment · Fixed by #130

Comments

@johnsoncarlp
Copy link

Bug Report

Rustc version required. Update README and if possible add to toml for packages.

Version

all up to 0.0.9-alpha

Platform

Darwin 19.6.0 Darwin Kernel Version 19.6.0: Thu May 6 00:48:39 PDT 2021; root:xnu-6153.141.33~1/RELEASE_X86_64 x86_64

Description

rust-lang/rust#63514

rustc min version for features used. For example, poll was an unstable feature until early 2021, so if features like poll are used we should put the min rustc version required in the Cargo.toml so the user compiling can quickly diagnose vs hunting for a supported version.

In this sample the version required is 1.51.0 and of course I was on 1.49.0 ..

https://github.com/awslabs/aws-sdk-rust/blob/00c6d6f350cf45e2cdd8e3a9fdec6e24bbb63142/sdk/smithy-http/Cargo.toml

@jdisanti
Copy link
Contributor

Thanks for reporting this!

It looks like support for specifying the minimum supported Rust version isn't implemented in Cargo yet, so we'll have to settle for a README update for now.

Related issue: #128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants