Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex Crate using Unicode #772

Closed
2 tasks
0cv opened this issue Mar 31, 2023 · 3 comments
Closed
2 tasks

Regex Crate using Unicode #772

0cv opened this issue Mar 31, 2023 · 3 comments
Labels
feature-request A feature should be added or improved.

Comments

@0cv
Copy link

0cv commented Mar 31, 2023

Describe the feature

Many crates are using Regex such as aws-sdk-appconfig, aws-sdk-appconfigdata, aws-endpoint, aws-sdk-ses (and many more).

By default, Unicode tables are contained within the Regex crate, which increases notably the size of the compiled binary. It would be good if a flag could be passed to deactivate unicode tables when not needed, as mentioned in the Regex crate https://github.com/rust-lang/regex#crate-features

Use Case

Decrease binary size when unicode is not needed.

Proposed Solution

Add a feature flag at the aws-* crates level, that can change the features of the Regex crate.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

A note for the community

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue, please leave a comment
@0cv 0cv added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 31, 2023
@ysaito1001
Copy link
Collaborator

Hi @0cv, given the benefit, this is an interesting request. Thank you for submitting it.

@ysaito1001 ysaito1001 removed the needs-triage This issue or PR still needs to be triaged. label Mar 31, 2023
@ysaito1001
Copy link
Collaborator

As part of smithy-lang/smithy-rs#3269, the regex crate has been replaced by the regex-lite crate. The primary motivation for the PR was to reduce client initialization time at runtime, but it should also help reduce the size of the complied binary, as noted in rust-lang/regex#961 (comment).

Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

2 participants