Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent API Gateway Authentication Between Constructs #37

Closed
purplebari opened this issue Aug 11, 2020 · 1 comment
Closed

Inconsistent API Gateway Authentication Between Constructs #37

purplebari opened this issue Aug 11, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@purplebari
Copy link

purplebari commented Aug 11, 2020

Adding the following property to the props object for ApiGatewayLambda and ApiGatewayDynamoDb causes the API Gateway to be launched with no authentication.

      apiGatewayProps: {
        defaultMethodOptions: {
          authorizationType: api.AuthorizationType.NONE
        }
      }

Adding the same property to the props object for ApiGatewaySqs is ignored and no message is provided to the user that they are not getting the behavior they requested.

Reproduction Steps

Line 189 of aws-apigateway-sqs is:

  authorizationType: api.AuthorizationType.IAM,

This is not found in the same addMethod() function in aws-apigateway-dynamodb.

It might be worth considering moving this function to core/apigatewayhelper.ts to remove the redundant implementations and ensure behavior stays consistent in the future.

Error Log

N/A

Environment

  • **CDK CLI Version :1.56.0
  • **CDK Framework Version:1.56.0
  • **AWS Solutions Constructs Version :1.56.0
  • **OS :macOS
  • **Language :typescript

Other


This is 🐛 Bug Report

@purplebari purplebari added bug Something isn't working needs-triage The issue or PR still needs to be triaged labels Aug 11, 2020
@hnishar hnishar added in-progress This issue is being actively worked on and removed needs-triage The issue or PR still needs to be triaged labels Aug 11, 2020
@hnishar hnishar self-assigned this Aug 11, 2020
@hnishar hnishar removed the in-progress This issue is being actively worked on label Aug 15, 2020
@hnishar
Copy link
Contributor

hnishar commented Aug 15, 2020

purplebari@ This bug has been fixed in the latest release v1.58.0

@hnishar hnishar closed this as completed Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants