Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3ToStepFunctions: add a SQS FIFO Queue to get exactly-once delivery #794

Open
joshwand opened this issue Sep 12, 2022 · 3 comments
Open
Labels
feature-request A feature should be added or improved needs-triage The issue or PR still needs to be triaged

Comments

@joshwand
Copy link

In using this construct I found I was spending a lot more than expected because I was getting many duplicate events, and running my ML step function is quite expensive. I suggest adding a FIFO queue to get exactly-once delivery semantics (or change to an S3-SNS-SQS-Stepfunction workflow).

This is a 🚀 Feature Request

@joshwand joshwand added feature-request A feature should be added or improved needs-triage The issue or PR still needs to be triaged labels Sep 12, 2022
@biffgaut
Copy link
Contributor

Thanks - we'll take a look.

Just to get some additional info in advance, if we were to add a FIFO capability to S3-SQS, then create an SQS-StepFunctions construct, would that work for your use case?

@joshwand
Copy link
Author

Since I need something right away I'll be writing my own construct. While your suggestion does sound like it would work, IMO it would be better added to this construct, since to me the duplicate deliveries of S3 events is an undocumented and undesirable (and expensive!) behavior.

@biffgaut
Copy link
Contributor

That's a good argument for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved needs-triage The issue or PR still needs to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants